Ryan Gambord has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/17070 )

Change subject: mem-cache: Removed default arg from get() in prefetch/base.hh
......................................................................

mem-cache: Removed default arg from get() in prefetch/base.hh

commit b0d1643 caused building against NULL to break due to
NULLIsa::GuestByteOrder not being defined.

Removal of default argument in src/mem/cache/prefetch/base.hh fixes
this.

Change-Id: I99a4abb4be1418fadec145481164f7caa3334ca0
Signed-off-by: Ryan Gambord
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/17070
Reviewed-by: Daniel Carvalho <[email protected]>
Reviewed-by: Nikos Nikoleris <[email protected]>
Maintainer: Nikos Nikoleris <[email protected]>
---
M src/mem/cache/prefetch/base.hh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nikos Nikoleris: Looks good to me, approved; Looks good to me, approved
  Daniel Carvalho: Looks good to me, approved



diff --git a/src/mem/cache/prefetch/base.hh b/src/mem/cache/prefetch/base.hh
index 05895f2..3ef607f 100644
--- a/src/mem/cache/prefetch/base.hh
+++ b/src/mem/cache/prefetch/base.hh
@@ -201,7 +201,7 @@
          */
         template <typename T>
         inline T
-        get(ByteOrder endian = TheISA::GuestByteOrder) const
+        get(ByteOrder endian) const
         {
             if (data == nullptr) {
panic("PrefetchInfo::get called with a request with no data.");

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/17070
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I99a4abb4be1418fadec145481164f7caa3334ca0
Gerrit-Change-Number: 17070
Gerrit-PatchSet: 5
Gerrit-Owner: Ryan Gambord <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Javier Bueno Hedo <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: Ryan Gambord <[email protected]>
Gerrit-CC: Gabe Black <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to