Hello Nikos Nikoleris,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/17531
to look at the new patch set (#2).
Change subject: mem-cache: Remove address awareness from queue_entry
......................................................................
mem-cache: Remove address awareness from queue_entry
A queue entry was created due to a writeback (or similar) happening,
or a miss, and these have packets. These packets have a copy of the
address, and therefore although having a local copy would speed
things up, it adds assumptions of the packet model to the queue entry.
This blocks, for example, the introduction of compressed packets,
which may refer to multiple addresses instead of just one. With this
change we forward the address handling to the packet.
Change-Id: Ic3b6c4693461932f0951840518df5053b9b3ab4e
Signed-off-by: Daniel R. Carvalho <[email protected]>
---
M src/mem/cache/base.cc
M src/mem/cache/base.hh
M src/mem/cache/cache.cc
M src/mem/cache/mshr.cc
M src/mem/cache/mshr.hh
M src/mem/cache/mshr_queue.cc
M src/mem/cache/mshr_queue.hh
M src/mem/cache/queue_entry.hh
M src/mem/cache/write_queue.cc
M src/mem/cache/write_queue.hh
M src/mem/cache/write_queue_entry.cc
M src/mem/cache/write_queue_entry.hh
12 files changed, 36 insertions(+), 51 deletions(-)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/17531
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ic3b6c4693461932f0951840518df5053b9b3ab4e
Gerrit-Change-Number: 17531
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-MessageType: newpatchset
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
