Andrea Mondelli has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/18348 )
Change subject: cpu,mem: missing override specifier
......................................................................
cpu,mem: missing override specifier
Change-Id: I731d3ef021596450ac307461f215760a148bb28a
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/18348
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/cpu/simple_thread.hh
M src/mem/cache/mshr.hh
M src/mem/cache/write_queue_entry.hh
3 files changed, 14 insertions(+), 10 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/cpu/simple_thread.hh b/src/cpu/simple_thread.hh
index 46f142f..0d415dc 100644
--- a/src/cpu/simple_thread.hh
+++ b/src/cpu/simple_thread.hh
@@ -213,26 +213,30 @@
System *getSystemPtr() override { return system; }
TheISA::Kernel::Statistics *
- getKernelStats()
+ getKernelStats() override
{
return ThreadState::getKernelStats();
}
- PortProxy &getPhysProxy() { return ThreadState::getPhysProxy(); }
+ PortProxy &getPhysProxy() override { return
ThreadState::getPhysProxy(); }
FSTranslatingPortProxy &
- getVirtProxy()
+ getVirtProxy() override
{
return ThreadState::getVirtProxy();
}
- void initMemProxies(ThreadContext *tc) {
ThreadState::initMemProxies(tc); }
+ void initMemProxies(ThreadContext *tc) override
+ {
+ ThreadState::initMemProxies(tc);
+ }
+
SETranslatingPortProxy &
- getMemProxy()
+ getMemProxy() override
{
return ThreadState::getMemProxy();
}
- Process *getProcessPtr() { return ThreadState::getProcessPtr(); }
+ Process *getProcessPtr() override { return
ThreadState::getProcessPtr(); }
void setProcessPtr(Process *p) override {
ThreadState::setProcessPtr(p); }
Status status() const override { return _status; }
diff --git a/src/mem/cache/mshr.hh b/src/mem/cache/mshr.hh
index 4b05489..3e7b79e 100644
--- a/src/mem/cache/mshr.hh
+++ b/src/mem/cache/mshr.hh
@@ -352,7 +352,7 @@
assert(inService); return postDowngrade;
}
- bool sendPacket(BaseCache &cache);
+ bool sendPacket(BaseCache &cache) override;
bool allocOnFill() const {
return targets.allocOnFill;
@@ -523,7 +523,7 @@
*/
void print(std::ostream &os,
int verbosity = 0,
- const std::string &prefix = "") const;
+ const std::string &prefix = "") const override;
/**
* A no-args wrapper of print(std::ostream...) meant to be
* invoked from DPRINTFs avoiding string overheads in fast mode
diff --git a/src/mem/cache/write_queue_entry.hh
b/src/mem/cache/write_queue_entry.hh
index 9aaac49..907ef47 100644
--- a/src/mem/cache/write_queue_entry.hh
+++ b/src/mem/cache/write_queue_entry.hh
@@ -92,7 +92,7 @@
/** WriteQueueEntry list iterator. */
typedef List::iterator Iterator;
- bool sendPacket(BaseCache &cache);
+ bool sendPacket(BaseCache &cache) override;
private:
@@ -171,7 +171,7 @@
*/
void print(std::ostream &os,
int verbosity = 0,
- const std::string &prefix = "") const;
+ const std::string &prefix = "") const override;
/**
* A no-args wrapper of print(std::ostream...) meant to be
* invoked from DPRINTFs avoiding string overheads in fast mode
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18348
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I731d3ef021596450ac307461f215760a148bb28a
Gerrit-Change-Number: 18348
Gerrit-PatchSet: 2
Gerrit-Owner: Andrea Mondelli <[email protected]>
Gerrit-Reviewer: Andrea Mondelli <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
