Hello Andreas Sandberg,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/18390
to review the following change.
Change subject: dev-arm: Check for maximum number of supported PE in GICv3
......................................................................
dev-arm: Check for maximum number of supported PE in GICv3
This is currently set to 256
Change-Id: If7bb2847c22f29bfa0cb4ebf4a7984ee43ab4e29
Signed-off-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com>
---
M src/dev/arm/Gic.py
M src/dev/arm/gic_v3.cc
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/src/dev/arm/Gic.py b/src/dev/arm/Gic.py
index 6f7c8d9..8bc155f 100644
--- a/src/dev/arm/Gic.py
+++ b/src/dev/arm/Gic.py
@@ -178,3 +178,7 @@
"HV maintenance interrupt."
"ARM strongly recommends that maintenance interrupts "
"are configured to use INTID 25 (PPI Interrupt).")
+
+ cpu_max = Param.Unsigned(256,
+ "Maximum number of PE. This is affecting the maximum number of "
+ "redistributors")
diff --git a/src/dev/arm/gic_v3.cc b/src/dev/arm/gic_v3.cc
index a6bd3d8..cfc7df5 100644
--- a/src/dev/arm/gic_v3.cc
+++ b/src/dev/arm/gic_v3.cc
@@ -58,6 +58,11 @@
redistributors.resize(sys->numContexts(), nullptr);
cpuInterfaces.resize(sys->numContexts(), nullptr);
+ panic_if(sys->numContexts() > params()->cpu_max,
+ "Exceeding maximum number of PEs supported by GICv3: "
+ "using %u while maximum is %u\n", sys->numContexts(),
+ params()->cpu_max);
+
for (int i = 0; i < sys->numContexts(); i++) {
redistributors[i] = new Gicv3Redistributor(this, i);
cpuInterfaces[i] = new Gicv3CPUInterface(this, i);
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18390
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: If7bb2847c22f29bfa0cb4ebf4a7984ee43ab4e29
Gerrit-Change-Number: 18390
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
