Hello Andreas Sandberg,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/18393
to review the following change.
Change subject: dev-arm: Move GICv3 (Re)Ditributor address in Realview.py
......................................................................
dev-arm: Move GICv3 (Re)Ditributor address in Realview.py
Base addresses for GICv3's Distributor and Redistributors are
implementation defined: they depend on the platform rather than the
model. This patch is then moving dist_addr and redist_addr
initialization in Realview.py
Change-Id: I1246df500262f4d3d5a38e62d0240945f90941ee
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-by: Andreas Sandberg <[email protected]>
---
M src/dev/arm/Gic.py
M src/dev/arm/RealView.py
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/dev/arm/Gic.py b/src/dev/arm/Gic.py
index 63ecc92..011e238 100644
--- a/src/dev/arm/Gic.py
+++ b/src/dev/arm/Gic.py
@@ -166,9 +166,9 @@
type = 'Gicv3'
cxx_header = "dev/arm/gic_v3.hh"
- dist_addr = Param.Addr(0x2c000000, "Address for distributor")
+ dist_addr = Param.Addr("Address for distributor")
dist_pio_delay = Param.Latency('10ns', "Delay for PIO r/w to
distributor")
- redist_addr = Param.Addr(0x2c010000, "Address for redistributors")
+ redist_addr = Param.Addr("Address for redistributors")
redist_pio_delay = Param.Latency('10ns',
"Delay for PIO r/w to redistributors")
it_lines = Param.UInt32(1020,
diff --git a/src/dev/arm/RealView.py b/src/dev/arm/RealView.py
index f83f075..186d6df 100644
--- a/src/dev/arm/RealView.py
+++ b/src/dev/arm/RealView.py
@@ -1083,7 +1083,8 @@
]
class VExpress_GEM5_V2_Base(VExpress_GEM5_Base):
- gic = Gicv3(maint_int=ArmPPI(num=25))
+ gic = Gicv3(dist_addr=0x2c000000, redist_addr=0x2c010000,
+ maint_int=ArmPPI(num=25))
# Limiting to 128 since it will otherwise overlap with PCI space
gic.cpu_max = 128
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18393
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I1246df500262f4d3d5a38e62d0240945f90941ee
Gerrit-Change-Number: 18393
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
