Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/18175 )
Change subject: python: Get rid of the VectorPort constructor.
......................................................................
python: Get rid of the VectorPort constructor.
The only thing it was doing beyond calling the parent Port __init__ was
to set isVec, and nobody actually looks at that value later.
Change-Id: I567cb583e6f02a6c18504b9bb20dd13b3c934822
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/18175
Tested-by: kokoro <[email protected]>
Reviewed-by: Andreas Sandberg <[email protected]>
Maintainer: Andreas Sandberg <[email protected]>
---
M src/python/m5/params.py
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/python/m5/params.py b/src/python/m5/params.py
index 8b0a14a..02f5e51 100644
--- a/src/python/m5/params.py
+++ b/src/python/m5/params.py
@@ -2115,11 +2115,6 @@
# VectorPort description object. Like Port, but represents a vector
# of connections (e.g., as on a XBar).
class VectorPort(Port):
- # VectorPort("role", "description")
- def __init__(self, role, desc, is_source=False):
- super(VectorPort, self).__init__(role, desc, is_source)
- self.isVec = True
-
def makeRef(self, simobj):
return VectorPortRef(simobj, self.name, self.role, self.is_source)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18175
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I567cb583e6f02a6c18504b9bb20dd13b3c934822
Gerrit-Change-Number: 18175
Gerrit-PatchSet: 5
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
