Change subject: dev-arm: Add named variable for GICD_TYPER.IDBits ......................................................................
dev-arm: Add named variable for GICD_TYPER.IDBits This could be used by other GICv3 components to query the maximum number of implemented interrupt identifiers Change-Id: I132e50de331aea22523260bcefba7e961b53eccd Signed-off-by: Giacomo Travaglini <[email protected]> Reviewed-by: Andreas Sandberg <[email protected]> Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/18599 Maintainer: Andreas Sandberg <[email protected]> Tested-by: kokoro <[email protected]> --- M src/dev/arm/gic_v3_distributor.cc M src/dev/arm/gic_v3_distributor.hh 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Andreas Sandberg: Looks good to me, approved; Looks good to me, approved kokoro: Regressions passdiff --git a/src/dev/arm/gic_v3_distributor.cc b/src/dev/arm/gic_v3_distributor.cc
index f261b29..a048d18 100644
--- a/src/dev/arm/gic_v3_distributor.cc
+++ b/src/dev/arm/gic_v3_distributor.cc
@@ -472,7 +472,7 @@
{
int max_spi_int_id = itLines - 1;
int it_lines_number = ceil((max_spi_int_id + 1) / 32.0) - 1;
- return (1 << 26) | (1 << 25) | (1 << 24) | (0xf << 19) |
+ return (1 << 26) | (1 << 25) | (1 << 24) | (IDBITS << 19) |
(1 << 17) | (gic->getSystem()->haveSecurity() << 10) |
(it_lines_number << 0);
}
diff --git a/src/dev/arm/gic_v3_distributor.hh
b/src/dev/arm/gic_v3_distributor.hh
index 86e53a3..c231438 100644
--- a/src/dev/arm/gic_v3_distributor.hh
+++ b/src/dev/arm/gic_v3_distributor.hh
@@ -140,6 +140,7 @@
public:
static const uint32_t ADDR_RANGE_SIZE = 0x10000;
+ static const uint32_t IDBITS = 0xf;
protected:
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18599
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I132e50de331aea22523260bcefba7e961b53eccd Gerrit-Change-Number: 18599 Gerrit-PatchSet: 3 Gerrit-Owner: Giacomo Travaglini <[email protected]> Gerrit-Reviewer: Andreas Sandberg <[email protected]> Gerrit-Reviewer: Giacomo Travaglini <[email protected]> Gerrit-Reviewer: kokoro <[email protected]> Gerrit-MessageType: merged _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
