Po-Hao Su has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/18928
Change subject: mem: Fix using the wrong access function in timing mode
......................................................................
mem: Fix using the wrong access function in timing mode
We should not use the atomic mode function in the timing mode,
because it may cause incorrect semantics when the features are
expanded in the future.
Change-Id: Iec0a3d1054243528fb8eb5bd441bfa07ab267fc7
Signed-off-by: Po-Hao Su <[email protected]>
---
M src/mem/simple_mem.cc
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mem/simple_mem.cc b/src/mem/simple_mem.cc
index 9e7dfc8..df48c64 100644
--- a/src/mem/simple_mem.cc
+++ b/src/mem/simple_mem.cc
@@ -157,10 +157,10 @@
// go ahead and deal with the packet and put the response in the
// queue if there is one
bool needsResponse = pkt->needsResponse();
- recvAtomic(pkt);
+ access(pkt);
// turn packet around to go back to requester if response expected
if (needsResponse) {
- // recvAtomic() should already have turned packet into
+ // access() should already have turned packet into
// atomic response
assert(pkt->isResponse());
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18928
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Iec0a3d1054243528fb8eb5bd441bfa07ab267fc7
Gerrit-Change-Number: 18928
Gerrit-PatchSet: 1
Gerrit-Owner: Po-Hao Su <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
