Hello Ciro Santilli,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/19149
to review the following change.
Change subject: arch-arm: Fix WalkerState,Descriptors default constructor
......................................................................
arch-arm: Fix WalkerState,Descriptors default constructor
Those POD strutures are not initializing all members at construction.
This could lead to undefined behaviour
Change-Id: Iaa8afb126382b6bfbef686883a026262f24d5ca1
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-by: Ciro Santilli <[email protected]>
Reviewed-by: Javier Setoain <[email protected]>
---
M src/arch/arm/table_walker.cc
M src/arch/arm/table_walker.hh
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/arch/arm/table_walker.cc b/src/arch/arm/table_walker.cc
index 6f06b71..461194d 100644
--- a/src/arch/arm/table_walker.cc
+++ b/src/arch/arm/table_walker.cc
@@ -130,7 +130,10 @@
TableWalker::WalkerState::WalkerState() :
tc(nullptr), aarch64(false), el(EL0), physAddrRange(0), req(nullptr),
asid(0), vmid(0), isHyp(false), transState(nullptr),
- vaddr(0), vaddr_tainted(0), isWrite(false), isFetch(false),
isSecure(false),
+ vaddr(0), vaddr_tainted(0),
+ sctlr(0), scr(0), cpsr(0), tcr(0),
+ htcr(0), hcr(0), vtcr(0),
+ isWrite(false), isFetch(false), isSecure(false),
secureLookup(false), rwTable(false), userTable(false), xnTable(false),
pxnTable(false), stage2Req(false),
stage2Tran(nullptr), timing(false), functional(false),
diff --git a/src/arch/arm/table_walker.hh b/src/arch/arm/table_walker.hh
index 752b57a..dacde64 100644
--- a/src/arch/arm/table_walker.hh
+++ b/src/arch/arm/table_walker.hh
@@ -67,6 +67,8 @@
class DescriptorBase {
public:
+ DescriptorBase() : lookupLevel(L0) {}
+
/** Current lookup level for this descriptor */
LookupLevel lookupLevel;
@@ -382,6 +384,8 @@
Page
};
+ LongDescriptor() : data(0), _dirty(false) {}
+
/** The raw bits of the entry */
uint64_t data;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/19149
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Iaa8afb126382b6bfbef686883a026262f24d5ca1
Gerrit-Change-Number: 19149
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Ciro Santilli <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
