Hello Gabor Dozsa,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/19171
to review the following change.
Change subject: arch-arm: Fix tracing code for SVE gather
......................................................................
arch-arm: Fix tracing code for SVE gather
Printing the entire contents of the dest vecreg for each gather
microop is suboptimal as it creates false positive differences
between Atomic and O3 traces. This fix prints only the memory
data which a microop loads from memory.
Change-Id: Idd8e0b26a96f9c9cc0b69360174bedf6a9f6dcb5
Signed-off-by: Gabor Dozsa <[email protected]>
Reviewed-by: Giacomo Gabrielli <[email protected]>
---
M src/arch/arm/isa/templates/sve_mem.isa
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/arch/arm/isa/templates/sve_mem.isa
b/src/arch/arm/isa/templates/sve_mem.isa
index dced5f4..3085eca 100644
--- a/src/arch/arm/isa/templates/sve_mem.isa
+++ b/src/arch/arm/isa/templates/sve_mem.isa
@@ -1,4 +1,4 @@
-// Copyright (c) 2017-2018 ARM Limited
+// Copyright (c) 2017-2019 ARM Limited
// All rights reserved
//
// The license below extends only to copyright in the software and shall
@@ -560,7 +560,9 @@
if (fault == NoFault) {
%(fault_status_reset_code)s;
%(memacc_code)s;
- %(op_wb)s;
+ if (traceData) {
+ traceData->setData(memData);
+ }
} else {
%(fault_status_set_code)s;
if (firstFault) {
@@ -572,7 +574,9 @@
fault = NoFault;
memData = 0;
%(memacc_code)s;
- %(op_wb)s;
+ if (traceData) {
+ traceData->setData(memData);
+ }
}
}
}
@@ -638,7 +642,9 @@
}
%(memacc_code)s;
- %(op_wb)s;
+ if (traceData) {
+ traceData->setData(memData);
+ }
return NoFault;
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/19171
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Idd8e0b26a96f9c9cc0b69360174bedf6a9f6dcb5
Gerrit-Change-Number: 19171
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Gabrielli <[email protected]>
Gerrit-Reviewer: Gabor Dozsa <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
