Daniel Carvalho has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/18739 )
Change subject: mem-ruby: Fix MultiGrainBloomFilter accessing
......................................................................
mem-ruby: Fix MultiGrainBloomFilter accessing
When accessing the page filter the page hash should be used
instead of the hash of the base filter.
Change-Id: I17b7c64f2a0d654c7d9a77a7bfb435385d81032c
Signed-off-by: Daniel R. Carvalho <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/18739
Maintainer: Nikos Nikoleris <[email protected]>
Tested-by: kokoro <[email protected]>
Reviewed-by: Nikos Nikoleris <[email protected]>
---
M src/mem/ruby/filters/MultiGrainBloomFilter.cc
1 file changed, 11 insertions(+), 9 deletions(-)
Approvals:
Nikos Nikoleris: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/mem/ruby/filters/MultiGrainBloomFilter.cc
b/src/mem/ruby/filters/MultiGrainBloomFilter.cc
index d91eb7f..150e0a5 100644
--- a/src/mem/ruby/filters/MultiGrainBloomFilter.cc
+++ b/src/mem/ruby/filters/MultiGrainBloomFilter.cc
@@ -54,21 +54,23 @@
void
MultiGrainBloomFilter::set(Addr addr)
{
- int i = hash(addr);
- assert(i < filter.size());
- assert(pageHash(addr) < pageFilter.size());
- filter[i] = 1;
- pageFilter[i] = 1;
+ const int index = hash(addr);
+ assert(index < filter.size());
+ filter[index] = 1;
+ const int page_index = pageHash(addr);
+ assert(page_index < pageFilter.size());
+ pageFilter[page_index] = 1;
}
int
MultiGrainBloomFilter::getCount(Addr addr) const
{
- int i = hash(addr);
- assert(i < filter.size());
- assert(pageHash(addr) < pageFilter.size());
- return filter[i] + pageFilter[i];
+ const int index = hash(addr);
+ const int page_index = pageHash(addr);
+ assert(index < filter.size());
+ assert(page_index < pageFilter.size());
+ return filter[index] + pageFilter[page_index];
}
int
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18739
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I17b7c64f2a0d654c7d9a77a7bfb435385d81032c
Gerrit-Change-Number: 18739
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
