Sure, now worries, it's not on top of our priority list 🙂 Many thanks
Giacomo ________________________________ From: Gabe Black <[email protected]> Sent: 09 August 2019 00:35 To: Giacomo Travaglini <[email protected]>; gem5 Developer List <[email protected]> Subject: Re: Change in gem5/gem5[master]: sim: Add getter to fault virtual address Hi Giacomo, sorry I haven't gotten to this yet, it's on my todo list. If I don't get to it in a while, feel free to ping me about it. Gabe On Thu, Jul 18, 2019 at 8:09 AM Giacomo Travaglini (Gerrit) <[email protected]<mailto:[email protected]>> wrote: Giacomo Travaglini submitted this change. View Change<https://gem5-review.googlesource.com/c/public/gem5/+/19176> Approvals: Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved kokoro: Regressions pass sim: Add getter to fault virtual address Change-Id: Ifd493aee9e78b0b4ddcc71e90f48679543acb861 Signed-off-by: Giacomo Gabrielli <[email protected]<mailto:[email protected]>> Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/19176 Reviewed-by: Giacomo Travaglini <[email protected]<mailto:[email protected]>> Maintainer: Giacomo Travaglini <[email protected]<mailto:[email protected]>> Tested-by: kokoro <[email protected]<mailto:noreply%[email protected]>> --- M src/sim/faults.hh 1 file changed, 2 insertions(+), 0 deletions(-) diff --git a/src/sim/faults.hh b/src/sim/faults.hh index 7475971..47855e7 100644 --- a/src/sim/faults.hh +++ b/src/sim/faults.hh @@ -99,6 +99,7 @@ GenericPageTableFault(Addr va) : vaddr(va) {} void invoke(ThreadContext * tc, const StaticInstPtr &inst = StaticInst::nullStaticInstPtr); + Addr getFaultVAddr() const { return vaddr; } }; class GenericAlignmentFault : public FaultBase @@ -110,6 +111,7 @@ GenericAlignmentFault(Addr va) : vaddr(va) {} void invoke(ThreadContext * tc, const StaticInstPtr &inst = StaticInst::nullStaticInstPtr); + Addr getFaultVAddr() const { return vaddr; } }; #endif // __FAULTS_HH__ To view, visit change 19176<https://gem5-review.googlesource.com/c/public/gem5/+/19176>. To unsubscribe, or for help writing mail filters, visit settings<https://gem5-review.googlesource.com/settings>. Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: Ifd493aee9e78b0b4ddcc71e90f48679543acb861 Gerrit-Change-Number: 19176 Gerrit-PatchSet: 4 Gerrit-Owner: Giacomo Gabrielli <[email protected]<mailto:[email protected]>> Gerrit-Reviewer: Gabe Black <[email protected]<mailto:[email protected]>> Gerrit-Reviewer: Gabor Dozsa <[email protected]<mailto:[email protected]>> Gerrit-Reviewer: Giacomo Travaglini <[email protected]<mailto:[email protected]>> Gerrit-Reviewer: Jason Lowe-Power <[email protected]<mailto:[email protected]>> Gerrit-Reviewer: kokoro <[email protected]<mailto:noreply%[email protected]>> Gerrit-CC: Juha Jäykkä <[email protected]<mailto:[email protected]>> Gerrit-MessageType: merged IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
