Anthony Gutierrez has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/17908 )
Change subject: arch: Bump MaxVecRegLenInBytes to 4096
......................................................................
arch: Bump MaxVecRegLenInBytes to 4096
The GPU model uses the generic vector register
containers, however the maximum vector register
length is fixed at 256, which is an invalid assumption
for the GPU model as it can operate on vectors up
to 4096B.
Change-Id: Id85e0ed45c9a9c1a4bb6e712c44eaeec2d628fce
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/17908
Reviewed-by: Anthony Gutierrez <[email protected]>
Maintainer: Anthony Gutierrez <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/generic/vec_reg.hh
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Anthony Gutierrez: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/generic/vec_reg.hh b/src/arch/generic/vec_reg.hh
index ed2545c..aab307b 100644
--- a/src/arch/generic/vec_reg.hh
+++ b/src/arch/generic/vec_reg.hh
@@ -154,7 +154,7 @@
#include "base/cprintf.hh"
#include "base/logging.hh"
-constexpr unsigned MaxVecRegLenInBytes = 256;
+constexpr unsigned MaxVecRegLenInBytes = 4096;
template <size_t Sz>
class VecRegContainer;
@@ -523,6 +523,7 @@
friend class VecRegContainer<32>;
friend class VecRegContainer<64>;
friend class VecRegContainer<128>;
+ friend class VecRegContainer<256>;
friend class VecRegContainer<MaxVecRegLenInBytes>;
/** My type alias. */
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/17908
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Id85e0ed45c9a9c1a4bb6e712c44eaeec2d628fce
Gerrit-Change-Number: 17908
Gerrit-PatchSet: 6
Gerrit-Owner: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Giacomo Gabrielli <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
