Base is for basic utilities like bitfield manipulation, endianess transformation, logging, etc. This sounds a lot more like it belongs in src/mem.
Gabe On Wed, Aug 28, 2019, 11:48 PM Daniel Carvalho (Gerrit) < [email protected]> wrote: > Hello kokoro, Anthony Gutierrez, Nikos Nikoleris, > > I'd like you to reexamine a change. Please visit > > https://gem5-review.googlesource.com/c/public/gem5/+/18875 > > to look at the new patch set (#6). > > Change subject: mem-ruby: Move Bloom Filters to base > ...................................................................... > > mem-ruby: Move Bloom Filters to base > > All Bloom Filters are completely independent of Ruby, and > therefore can be used everywhere. > > As a side effect, Ruby was not using the filters, so > their dependency was removed. > > Change-Id: Ic5f430610c33c0791fb81c79101ebe737189497e > Signed-off-by: Daniel R. Carvalho <[email protected]> > --- > R src/base/filters/BloomFilters.py > R src/base/filters/SConscript > R src/base/filters/base.hh > R src/base/filters/block_bloom_filter.cc > R src/base/filters/block_bloom_filter.hh > R src/base/filters/bulk_bloom_filter.cc > R src/base/filters/bulk_bloom_filter.hh > R src/base/filters/h3_bloom_filter.cc > R src/base/filters/h3_bloom_filter.hh > R src/base/filters/lsb_counting_bloom_filter.cc > R src/base/filters/lsb_counting_bloom_filter.hh > R src/base/filters/multi_bit_sel_bloom_filter.cc > R src/base/filters/multi_bit_sel_bloom_filter.hh > R src/base/filters/multi_bloom_filter.cc > R src/base/filters/multi_bloom_filter.hh > M src/mem/ruby/SConscript > M src/mem/ruby/protocol/RubySlicc_Types.sm > 17 files changed, 108 insertions(+), 83 deletions(-) > > > -- > To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18875 > To unsubscribe, or for help writing mail filters, visit > https://gem5-review.googlesource.com/settings > > Gerrit-Project: public/gem5 > Gerrit-Branch: master > Gerrit-Change-Id: Ic5f430610c33c0791fb81c79101ebe737189497e > Gerrit-Change-Number: 18875 > Gerrit-PatchSet: 6 > Gerrit-Owner: Daniel Carvalho <[email protected]> > Gerrit-Reviewer: Anthony Gutierrez <[email protected]> > Gerrit-Reviewer: Nikos Nikoleris <[email protected]> > Gerrit-Reviewer: kokoro <[email protected]> > Gerrit-MessageType: newpatchset > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
