Daniel Carvalho has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/21082 )
Change subject: mem-ruby: Remove maskHighOrderBits
......................................................................
mem-ruby: Remove maskHighOrderBits
Function was not being used. If needed, src/base/bitfield.hh's
mbits can be used instead:
maskHighOrderBits(addr, pos) == mbits<Addr>(addr, 64-pos, 0)
Change-Id: I3abd041f8d256ec157ba7502182d8588721c2a05
Signed-off-by: Daniel R. Carvalho <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/21082
Reviewed-by: Nikos Nikoleris <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Reviewed-by: Anthony Gutierrez <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/mem/ruby/common/Address.cc
M src/mem/ruby/common/Address.hh
2 files changed, 0 insertions(+), 14 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, but someone else must approve; Looks
good to me, approved
Nikos Nikoleris: Looks good to me, approved
Anthony Gutierrez: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/mem/ruby/common/Address.cc b/src/mem/ruby/common/Address.cc
index edb4177..af8ddb4 100644
--- a/src/mem/ruby/common/Address.cc
+++ b/src/mem/ruby/common/Address.cc
@@ -59,19 +59,6 @@
}
Addr
-maskHighOrderBits(Addr addr, unsigned int number)
-{
- Addr mask;
-
- if (number >= ADDRESS_WIDTH - 1) {
- mask = ~0;
- } else {
- mask = (Addr)~0 >> number;
- }
- return (addr & mask);
-}
-
-Addr
shiftLowOrderBits(Addr addr, unsigned int number)
{
return (addr >> number);
diff --git a/src/mem/ruby/common/Address.hh b/src/mem/ruby/common/Address.hh
index 17490c4..6aed96a 100644
--- a/src/mem/ruby/common/Address.hh
+++ b/src/mem/ruby/common/Address.hh
@@ -40,7 +40,6 @@
// selects bits inclusive
Addr bitSelect(Addr addr, unsigned int small, unsigned int big);
Addr maskLowOrderBits(Addr addr, unsigned int number);
-Addr maskHighOrderBits(Addr addr, unsigned int number);
Addr shiftLowOrderBits(Addr addr, unsigned int number);
Addr getOffset(Addr addr);
Addr makeLineAddress(Addr addr);
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/21082
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I3abd041f8d256ec157ba7502182d8588721c2a05
Gerrit-Change-Number: 21082
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
