Brandon Potter has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/18068 )
Change subject: sim-se: Fix invalid delete of params on clone
......................................................................
sim-se: Fix invalid delete of params on clone
The params pointer is kept by the SimObject and should not be deleted
until gem5 exits. Added a to do to remember this object is leaked.
Change-Id: I46cc23a09e4e9b6bc2fdcd961148324c41820815
Signed-off-by: Jason Lowe-Power <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/18068
Tested-by: kokoro <[email protected]>
Maintainer: Brandon Potter <[email protected]>
Reviewed-by: Brandon Potter <[email protected]>
---
M src/sim/syscall_emul.hh
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Brandon Potter: Looks good to me, approved; Looks good to me, approved
Jason Lowe-Power: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/sim/syscall_emul.hh b/src/sim/syscall_emul.hh
index 130791d..fb6e9a1 100644
--- a/src/sim/syscall_emul.hh
+++ b/src/sim/syscall_emul.hh
@@ -1562,7 +1562,9 @@
pp->useArchPT = p->useArchPT;
pp->kvmInSE = p->kvmInSE;
Process *cp = pp->create();
- delete pp;
+ // TODO: there is no way to know when the Process SimObject is done
with
+ // the params pointer. Both the params pointer (pp) and the process
+ // pointer (cp) are normally managed in python and are never cleaned
up.
Process *owner = ctc->getProcessPtr();
ctc->setProcessPtr(cp);
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18068
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I46cc23a09e4e9b6bc2fdcd961148324c41820815
Gerrit-Change-Number: 18068
Gerrit-PatchSet: 6
Gerrit-Owner: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Alexandru Duțu <[email protected]>
Gerrit-Reviewer: Brandon Potter <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
