Hey Gabe, Sorry for not looking into these much so far. Honestly, I've been intimidated by the huge length of the patch chain and the complexity of the code.
Could you explain in more detail here or on the Jira issue what's going on? https://gem5.atlassian.net/browse/GEM5-187 I'd like to understand better the need for the complexity of this code and why it can't be implemented in a simpler way. I'd also like to understand what the high level changes are going to be. What will the API be at the end of all of these changes? How are these changes going to affect our end users? I guess the GuestABI stuff has all passed me by. I'm not sure I understand guest_abi.hh *at all*. What's this code doing? Why does it need so many levels of template arguments? I'm generally concerned with the complexity of this code. It's going to be a nightmare to try to debug a system call or a pseudo instruction with gdb given all of these templated functions (and even a recursive template function in guest_abi.hh!). Thanks, Jason On Mon, Dec 16, 2019 at 11:02 PM Gabe Black <gabebl...@google.com> wrote: > Hi folks. I have a lot of pending CLs in flight right now, I think about 70 > of which are currently active. That's a lot, so I thought I'd point out the > ones which, from my perspective, are the highest priority. > > Top priority would be this one, the next one in my GuestABI series: > > https://gem5-review.googlesource.com/c/public/gem5/+/23178 > > After that are the 6 GDB related ones currently starting here: > > https://gem5-review.googlesource.com/c/public/gem5/+/22118 > > Giacomo has been doing a great job reviewing those so far, but we're still > crunching through them. > > Finally, it would be nice to get this one in to close out it's little > peripheral series: > > https://gem5-review.googlesource.com/c/public/gem5/+/23361 > > Beyond that plowing into the remaining 60 or so GuestABI patches would be > great. I've got a design doc for that mechanism which will hopefully make > the rounds internally in the near future, and then I'll share it on > gem5-dev to give folks a better idea of what's going on without having to > decipher the code itself. > > But to reiterate, the top priority for me is that first one above. Getting > that in is blocking some other work I'm trying to do with Fast Model, so > sooner would be better than later. > > Gabe > _______________________________________________ > gem5-dev mailing list > gem5-dev@gem5.org > http://m5sim.org/mailman/listinfo/gem5-dev _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
