Apologies to all for this force push on Gerrit. Complete accident!

This commit was supposed to stop non-maintainers from modifying the master
branch as part of our "master-as-stable/develop-branch" transition. Though
from playing around it doesn't appear to have had this effect (a
non-maintainer in our lab was able to commit just fine). Please let me know
if this has stopped anyone from submitting. I created a revert commit, but
I'm having trouble figuring out how to get it merged...

--
Dr. Bobby R. Bruce
Room 2235,
Kemper Hall, UC Davis
Davis,
CA, 95616

web: https://www.bobbybruce.net


On Wed, Jan 15, 2020 at 2:22 PM Bobby R. Bruce (Gerrit)
<[email protected]> wrote:

> Bobby R. Bruce has submitted this change. (
> https://gem5-review.googlesource.com/c/public/gem5/+/24444 )
>
> Change subject: misc: Updated Gerrit permissions to restrict editing of
> master
> ......................................................................
>
> misc: Updated Gerrit permissions to restrict editing of master
>
> In order to keep the `master` branch stable (and migrate development
> work to the `develop` branch), the Gerrit permissions have been updated
> so that:
>
> 1) Non-maintainers can't contribute changes to the master branch.
>
> 2) Maintainers can contribute via gerrit, though their ability to
> force-push to master has been revoked.
>
> Change-Id: I4569266fb64b3b3aea156091b7f82fff7d14d315
> ---
> M groups
> M project.config
> 2 files changed, 15 insertions(+), 0 deletions(-)
>
>
>
> diff --git a/groups b/groups
> index 21e3028c..5c3e44b 100644
> --- a/groups
> +++ b/groups
> @@ -1,6 +1,9 @@
>   # UUID
> Group Name
>   #
>   9f2af4ea8cc5420a3b5522f7bb443767552e7124
> build-bots
> +global:Project-Owners                                          Project
> Owners
> +global:Registered-Users
> Registered
> Users
>   google:AI2Pq9p37HHM5dMXVBUchyYaIdDBMY0sESt44wvYMxS3DKM_l8KyVdo
> google/[email protected]
> +google:AI2Pq9qSiOlnnqcg5bMFxvrjLybzGAL6daxVAEF20YuIMIMysspMB4Y
> google/[email protected]
>   mdb:kokoro
> mdb/kokoro
>   mdb:kokoro-dedicated
> mdb/kokoro-dedicated
> diff --git a/project.config b/project.config
> index 26828d1..554aa87 100644
> --- a/project.config
> +++ b/project.config
> @@ -11,3 +11,15 @@
>         label-Verified = -1..+1 group google/[email protected]
>         label-Verified = -1..+1 group mdb/kokoro
>         label-Verified = -1..+1 group mdb/kokoro-dedicated
> +[access "refs/for/master"]
> +       addPatchSet = deny group Registered Users
> +       push = deny group Registered Users
> +       push = group Project Owners
> +       push = group google/[email protected]
> +       pushMerge = deny group Registered Users
> +[access "refs/for/refs/heads/master"]
> +       addPatchSet = deny group Registered Users
> +       push = deny group Registered Users
> +       push = group Project Owners
> +       push = group google/[email protected]
> +       pushMerge = deny group Registered Users
>
> --
> To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/24444
> To unsubscribe, or for help writing mail filters, visit
> https://gem5-review.googlesource.com/settings
>
> Gerrit-Project: public/gem5
> Gerrit-Branch: refs/meta/config
> Gerrit-Change-Id: I4569266fb64b3b3aea156091b7f82fff7d14d315
> Gerrit-Change-Number: 24444
> Gerrit-PatchSet: 2
> Gerrit-Owner: Bobby R. Bruce <[email protected]>
> Gerrit-MessageType: merged
> _______________________________________________
> gem5-dev mailing list
> [email protected]
> http://m5sim.org/mailman/listinfo/gem5-dev
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to