Hello Gabe Black,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/27127
to review the following change.
Change subject: scons: Get rid of a redundant "Warning:" in the SConstruct.
......................................................................
scons: Get rid of a redundant "Warning:" in the SConstruct.
The "warning()" method already prints "Warning:", so putting it in the
message itself means it gets printed twice.
Change-Id: Ic157355958fdf56739f865a926ecba071bb25c5e
---
M SConstruct
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/SConstruct b/SConstruct
index f5eb0ca..8d5ac57 100755
--- a/SConstruct
+++ b/SConstruct
@@ -425,9 +425,9 @@
disable_lto = GetOption('no_lto')
if not disable_lto and main.get('BROKEN_INCREMENTAL_LTO', False) and \
not GetOption('force_lto'):
- warning('Warning: Your compiler doesn\'t support incremental
linking '
- 'and lto at the same time, so lto is being disabled. To
force '
- 'lto on anyway, use the --force-lto option. That will
disable '
+ warning('Your compiler doesn\'t support incremental linking and
lto '
+ 'at the same time, so lto is being disabled. To force lto
on '
+ 'anyway, use the --force-lto option. That will disable '
'partial linking.')
disable_lto = True
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/27127
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic157355958fdf56739f865a926ecba071bb25c5e
Gerrit-Change-Number: 27127
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
