Sounds like a great idea to me. I fail to see any downside. -- Dr. Bobby R. Bruce Room 2235, Kemper Hall, UC Davis Davis, CA, 95616
web: https://www.bobbybruce.net On Tue, Mar 31, 2020 at 7:03 PM Gabe Black <gabebl...@google.com> wrote: > Hi folks. I (and probably many of you) have noticed that gerrit sometimes > decides something needs to be rebased when it doesn't really seem to, and > that rebase ends up forcing a rerun of verification which delays getting a > patch checked in, and incurs extra cost for gem5 for the compute resources > which run the verification. > > I asked for potential solutions from the gerrit team within google, and > they suggested turning on this property of the verified label: > > > https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_copyAllScoresOnTrivialRebase > > They said that since we already have the "Rebase Always" merge strategy > selected it wouldn't reduce the level of verification for changes, and > while it wouldn't avoid having to do trivial rebases (there's a button in > gerrit for that), it would avoid having to rerun verification. > > Note that this would not make the verification label permanent, it would > just mean that as long as the rebase was trivial (no commit message change, > no diff change including context lines) then it would stay verified. > > Does that sound like a good idea to everyone? If so, I can look into how to > make that happen. > > Gabe > _______________________________________________ > gem5-dev mailing list > gem5-dev@gem5.org > http://m5sim.org/mailman/listinfo/gem5-dev _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
