Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/27232 )
Change subject: util: Eliminate the sw99param m5 utility command.
......................................................................
util: Eliminate the sw99param m5 utility command.
This is a small additional layer on top of the initparam command and
just breaks the returned value into 12 bit chunks. It presumes that
there is some particular meaning to the default initparam value which
may or may not be true. It's not entirely clear what the 12 bit chunks
that this command returns are actually good for, and it's been around
long enough that there isn't really any good documentation about what
it's intended purpose was.
Change-Id: I21af0e0cf7501f47026a6dd31920d46cfccff167
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/27232
Maintainer: Gabe Black <gabebl...@google.com>
Tested-by: kokoro <noreply+kok...@google.com>
Reviewed-by: Bobby R. Bruce <bbr...@ucdavis.edu>
---
M util/m5/src/m5.c
1 file changed, 0 insertions(+), 17 deletions(-)
Approvals:
Bobby R. Bruce: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/util/m5/src/m5.c b/util/m5/src/m5.c
index eeaf621..de382d0 100644
--- a/util/m5/src/m5.c
+++ b/util/m5/src/m5.c
@@ -283,21 +283,6 @@
printf("%"PRIu64, val);
}
-void
-do_sw99param(int argc, char *argv[])
-{
- if (argc != 0)
- usage();
-
- uint64_t param = m5_init_param(0, 0);
-
- // run-time, rampup-time, rampdown-time, warmup-time, connections
- printf("%"PRId64" %"PRId64" %"PRId64" %"PRId64" %"PRId64,
- (param >> 48) & 0xfff,
- (param >> 36) & 0xfff, (param >> 24) & 0xfff,
- (param >> 12) & 0xfff, (param >> 0) & 0xfff);
-}
-
struct MainFunc
{
char *name;
@@ -340,8 +325,6 @@
"delay (default 0) reset the "
"stats, and then optionally "
"every period after" },
- { "sw99param", do_sw99param, "read the default initparam
and "
- "display it in 12 bit chunks"}
{ "writefile", do_write_file, "<filename> [host filename]
// "
"Write a file to the host, "
"optionally with a different "
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/27232
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I21af0e0cf7501f47026a6dd31920d46cfccff167
Gerrit-Change-Number: 27232
Gerrit-PatchSet: 11
Gerrit-Owner: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Earl Ou <shunhsin...@google.com>
Gerrit-Reviewer: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: Yu-hsin Wang <yuhsi...@google.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
