Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/29172 )
Change subject: x86: Stop setting the physical address in finalizePhysical.
......................................................................
x86: Stop setting the physical address in finalizePhysical.
The physical address has already been set (it's read earlier in the
function), and so doesn't need to be set again. Reading the virtual
address can cause an assert if the virtual address had never been set in
the first place, for example when an access comes from KVM which might
give you an access to complete which is based on a physical address
only.
Change-Id: Ic46a40b1a94235538b5bd53065e5019273b3d3f3
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/29172
Maintainer: Jason Lowe-Power <power...@gmail.com>
Reviewed-by: Pouya Fotouhi <pfoto...@ucdavis.edu>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/arch/x86/tlb.cc
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Pouya Fotouhi: Looks good to me, approved
Jason Lowe-Power: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/x86/tlb.cc b/src/arch/x86/tlb.cc
index 71ab563..8068423 100644
--- a/src/arch/x86/tlb.cc
+++ b/src/arch/x86/tlb.cc
@@ -264,7 +264,6 @@
req->setFlags(Request::STRICT_ORDER);
uint8_t func;
PseudoInst::decodeAddrOffset(paddr - m5opRange.start(), func);
- req->setPaddr(req->getVaddr());
req->setLocalAccessor(
[func, mode](ThreadContext *tc, PacketPtr pkt) -> Cycles
{
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/29172
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: release-staging-v20.0.0.0
Gerrit-Change-Id: Ic46a40b1a94235538b5bd53065e5019273b3d3f3
Gerrit-Change-Number: 29172
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Ayaz Akram <yazak...@ucdavis.edu>
Gerrit-Reviewer: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Bradford Beckmann <brad.beckm...@amd.com>
Gerrit-Reviewer: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: Pouya Fotouhi <pfoto...@ucdavis.edu>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
