Hello Matthew Poremba, Tony Gutierrez,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/29916
to review the following change.
Change subject: gpu-compute: remove recvToken from GM pipe exec
......................................................................
gpu-compute: remove recvToken from GM pipe exec
Tokens were previously acquired in GM pipe exec but has been moved to
acqCoalescerToken. This removes the extraneous code which was acquiring
tokens twice, causing them to be depleted and triggering an assertion.
Change-Id: Ic92de8f06cc85828b29c69790bdadde057ef1777
---
M src/gpu-compute/global_memory_pipeline.cc
1 file changed, 0 insertions(+), 6 deletions(-)
diff --git a/src/gpu-compute/global_memory_pipeline.cc
b/src/gpu-compute/global_memory_pipeline.cc
index 0bbacc4..c73184a 100644
--- a/src/gpu-compute/global_memory_pipeline.cc
+++ b/src/gpu-compute/global_memory_pipeline.cc
@@ -190,12 +190,6 @@
DPRINTF(GPUCoalescer, "initiateAcc for %s seqNum %d\n",
mp->disassemble(), mp->seqNum());
- // Memfences will not return tokens and must be issued so we should
- // not request one as this will deplete the token count until
deadlock
- if (!mp->isMemSync()) {
- assert(mp->computeUnit()->getTokenManager()->haveTokens(1));
- mp->computeUnit()->getTokenManager()->acquireTokens(1);
- }
mp->initiateAcc(mp);
if (((mp->isMemSync() && !mp->isEndOfKernel()) |
| !mp->isMemSync())) {
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/29916
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic92de8f06cc85828b29c69790bdadde057ef1777
Gerrit-Change-Number: 29916
Gerrit-PatchSet: 1
Gerrit-Owner: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Matthew Poremba <[email protected]>
Gerrit-Reviewer: Tony Gutierrez <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
