Hello Tony Gutierrez, Xianwei Zhang,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/29918
to review the following change.
Change subject: config: fix settings of kernel boundary sync flags
......................................................................
config: fix settings of kernel boundary sync flags
Change-Id: I58a8edc5d324bdcaa84e3d715e2712a43e8ede0d
---
M configs/example/apu_se.py
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/configs/example/apu_se.py b/configs/example/apu_se.py
index fee85f0..0ff80d8 100644
--- a/configs/example/apu_se.py
+++ b/configs/example/apu_se.py
@@ -209,13 +209,23 @@
# So, all GPU protocols other than GPU_RfO should make their writes
# visible to the global memory and should read from global memory
# during kernal boundary. The pipeline initiates(or do not initiate)
-# the acquire/release operation depending on this impl_kern_boundary_sync
-# flag. This flag=true means pipeline initiates a acquire/release operation
-# at kernel boundary.
+# the acquire/release operation depending on these impl_kern_launch_rel
+# and impl_kern_end_rel flags. The flag=true means pipeline initiates
+# a acquire/release operation at kernel launch/end.
+# VIPER protocols (GPU_VIPER, GPU_VIPER_Region and GPU_VIPER_Baseline)
+# are write-through based, and thus only imple_kern_launch_acq needs to
+# set.
if buildEnv['PROTOCOL'] == 'GPU_RfO':
- shader.impl_kern_boundary_sync = False
+ shader.impl_kern_launch_acq = False
+ shader.impl_kern_end_rel = False
+elif (buildEnv['PROTOCOL'] != 'GPU_VIPER' or
+ buildEnv['PROTOCOL'] != 'GPU_VIPER_Region' or
+ buildEnv['PROTOCOL'] != 'GPU_VIPER_Baseline'):
+ shader.impl_kern_launch_acq = True
+ shader.impl_kern_end_rel = False
else:
- shader.impl_kern_boundary_sync = True
+ shader.impl_kern_launch_acq = True
+ shader.impl_kern_end_rel = True
# Switching off per-lane TLB by default
per_lane = False
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/29918
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I58a8edc5d324bdcaa84e3d715e2712a43e8ede0d
Gerrit-Change-Number: 29918
Gerrit-PatchSet: 1
Gerrit-Owner: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Tony Gutierrez <[email protected]>
Gerrit-Reviewer: Xianwei Zhang <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
