Hello Tony Gutierrez,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/29929
to review the following change.
Change subject: gpu-compute: Remove unused function hostWakeUp from shader
......................................................................
gpu-compute: Remove unused function hostWakeUp from shader
Change-Id: Ib4415a7c5918da03bbd16fe9adb4dd593dcaa95c
---
M src/gpu-compute/shader.cc
M src/gpu-compute/shader.hh
2 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/src/gpu-compute/shader.cc b/src/gpu-compute/shader.cc
index aa7a6dd..f5e9444 100644
--- a/src/gpu-compute/shader.cc
+++ b/src/gpu-compute/shader.cc
@@ -153,19 +153,6 @@
assert(gpuTc);
}
-void
-Shader::hostWakeUp(BaseCPU *cpu) {
- if (cpuPointer == cpu) {
- if (gpuTc->status() == ThreadContext::Suspended)
- cpu->activateContext(gpuTc->threadId());
- } else {
- //Make sure both dispatcher and shader are trying to
- //wakeup same host. Hack here to enable kernel launch
- //from multiple CPUs
- panic("Dispatcher wants to wakeup a different host");
- }
-}
-
Shader*
ShaderParams::create()
{
diff --git a/src/gpu-compute/shader.hh b/src/gpu-compute/shader.hh
index eeaf343..238f6e0 100644
--- a/src/gpu-compute/shader.hh
+++ b/src/gpu-compute/shader.hh
@@ -301,7 +301,6 @@
Addr mmap(int length);
void functionalTLBAccess(PacketPtr pkt, int cu_id, BaseTLB::Mode mode);
void updateContext(int cid);
- void hostWakeUp(BaseCPU *cpu);
void notifyCuSleep();
};
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/29929
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib4415a7c5918da03bbd16fe9adb4dd593dcaa95c
Gerrit-Change-Number: 29929
Gerrit-PatchSet: 1
Gerrit-Owner: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Tony Gutierrez <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
