Hello Michael LeBeane, Tony Gutierrez,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/29928
to review the following change.
Change subject: arch-gcn3: Fix V_MAD_I32_I24 sign extension
......................................................................
arch-gcn3: Fix V_MAD_I32_I24 sign extension
We are not properly sign extending the bits we hack off for
V_MAD_I32_I24.
This fixes rnn_fwdBwd 64 1 1 lstm pte assertion failure.
Change-Id: I2516e5715227cbd822e6a62630674f64f7a109e0
---
M src/arch/gcn3/insts/instructions.cc
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/arch/gcn3/insts/instructions.cc
b/src/arch/gcn3/insts/instructions.cc
index 32719ad..0256d46 100644
--- a/src/arch/gcn3/insts/instructions.cc
+++ b/src/arch/gcn3/insts/instructions.cc
@@ -27446,8 +27446,8 @@
for (int lane = 0; lane < NumVecElemPerVecReg; ++lane) {
if (wf->execMask(lane)) {
- vdst[lane] = bits(src0[lane], 23, 0) * bits(src1[lane],
23, 0)
- + src2[lane];
+ vdst[lane] = sext<24>(bits(src0[lane], 23, 0))
+ * sext<24>(bits(src1[lane], 23, 0)) + src2[lane];
}
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/29928
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I2516e5715227cbd822e6a62630674f64f7a109e0
Gerrit-Change-Number: 29928
Gerrit-PatchSet: 1
Gerrit-Owner: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Michael LeBeane <[email protected]>
Gerrit-Reviewer: Tony Gutierrez <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
