Hello Michael LeBeane, Tony Gutierrez,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/29933
to review the following change.
Change subject: arch-gcn3: Fix writelane src0,src1 usage
......................................................................
arch-gcn3: Fix writelane src0,src1 usage
Src1 should only be used for lane select. The data should come
from src0.
Change-Id: Ibe960df2e56d351a3819b40194104d2972a5cd4c
---
M src/arch/gcn3/insts/instructions.cc
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/arch/gcn3/insts/instructions.cc
b/src/arch/gcn3/insts/instructions.cc
index 0256d46..b923eae 100644
--- a/src/arch/gcn3/insts/instructions.cc
+++ b/src/arch/gcn3/insts/instructions.cc
@@ -30181,7 +30181,7 @@
assert(!(extData.NEG & 0x2));
assert(!(extData.NEG & 0x4));
- vdst[src1.rawData() & 0x3f] = src1.rawData();
+ vdst[src1.rawData() & 0x3f] = src0.rawData();
vdst.write();
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/29933
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ibe960df2e56d351a3819b40194104d2972a5cd4c
Gerrit-Change-Number: 29933
Gerrit-PatchSet: 1
Gerrit-Owner: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Michael LeBeane <[email protected]>
Gerrit-Reviewer: Tony Gutierrez <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
