Hello Tony Gutierrez,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/29934
to review the following change.
Change subject: base, arch-gcn3: remove bitfield additions
......................................................................
base, arch-gcn3: remove bitfield additions
There already exists a reverseBits() function, so the
one we added is not needed.
In addition, the sext_32() function is not needed because
sign extending a 64b value and down casting to 32b is well
defined and safe to do.
Here, we remove our additions to bitfield.hh and update
our code accordingly.
Change-Id: I95286ab9a8de084a45ed1eca719cc21ce4bc9079
---
M src/base/bitfield.hh
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/base/bitfield.hh b/src/base/bitfield.hh
index 82c3307..99846ab 100644
--- a/src/base/bitfield.hh
+++ b/src/base/bitfield.hh
@@ -288,7 +288,7 @@
val++;
return val;
-};
+}
/**
* Count trailing zeros in a 32-bit value.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/29934
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I95286ab9a8de084a45ed1eca719cc21ce4bc9079
Gerrit-Change-Number: 29934
Gerrit-PatchSet: 1
Gerrit-Owner: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Tony Gutierrez <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
