Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/30654 )
Change subject: arm: Add a missing "break" in an ARM miscreg decode
function.
......................................................................
arm: Add a missing "break" in an ARM miscreg decode function.
This change accidentally left out a "break" which gcc found and
complained about.
arch-arm: Implementation of Hardware Breakpoint exception
This change adds in the break based on the assumption that the function
should not fall through that case to the next.
Change-Id: Id728a0c9a504d1b6d231d3fe1e7c5ece05d3ac4d
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/30654
Reviewed-by: Jordi Vaquero <[email protected]>
Maintainer: Giacomo Travaglini <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/arm/miscregs.cc
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Jordi Vaquero: Looks good to me, approved
Giacomo Travaglini: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/arm/miscregs.cc b/src/arch/arm/miscregs.cc
index 86b3aaa..2bdbaa4 100644
--- a/src/arch/arm/miscregs.cc
+++ b/src/arch/arm/miscregs.cc
@@ -201,8 +201,6 @@
return MISCREG_DBGBXVR15;
}
break;
- }
- switch (opc2) {
case 4:
switch (crm) {
case 0:
@@ -216,6 +214,7 @@
}
break;
}
+ break;
case 6:
switch (crm) {
case 0:
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/30654
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Id728a0c9a504d1b6d231d3fe1e7c5ece05d3ac4d
Gerrit-Change-Number: 30654
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jordi Vaquero <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
