Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/30434 )
Change subject: cpu: Get rid of auto return types in the PhysRegFile.
......................................................................
cpu: Get rid of auto return types in the PhysRegFile.
This is a C++14 feature, where we only support up to C++11 currently. It
also unnecessarily obfuscates what these functions are doing, since the
return type is a simple and fixed.
Change-Id: I7459ed885c3f006edbcecd4c6be9835d77dbbbae
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/30434
Reviewed-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Maintainer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/cpu/o3/regfile.cc
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/cpu/o3/regfile.cc b/src/cpu/o3/regfile.cc
index de9cd5e..e8164dc 100644
--- a/src/cpu/o3/regfile.cc
+++ b/src/cpu/o3/regfile.cc
@@ -180,8 +180,8 @@
freeList->addRegs(ccRegIds.begin(), ccRegIds.end());
}
-auto
-PhysRegFile::getRegElemIds(PhysRegIdPtr reg) -> IdRange
+PhysRegFile::IdRange
+PhysRegFile::getRegElemIds(PhysRegIdPtr reg)
{
panic_if(!reg->isVectorPhysReg(),
"Trying to get elems of a %s register", reg->className());
@@ -191,8 +191,8 @@
vecElemIds.begin() + (idx+1) * NumVecElemPerVecReg);
}
-auto
-PhysRegFile::getRegIds(RegClass cls) -> IdRange
+PhysRegFile::IdRange
+PhysRegFile::getRegIds(RegClass cls)
{
switch (cls)
{
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/30434
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I7459ed885c3f006edbcecd4c6be9835d77dbbbae
Gerrit-Change-Number: 30434
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
