Hello Nikos Nikoleris,

I'd like you to do a code review. Please visit

    https://gem5-review.googlesource.com/c/public/gem5/+/31080

to review the following change.


Change subject: arch-arm: Fix pmc == on SelfDebug
......................................................................

arch-arm: Fix pmc == on SelfDebug

The Assignment operator was used instead of the Equal-To

Change-Id: Ibf5a0006bce79b67d662fd1f8942699582956d58
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-by: Nikos Nikoleris <[email protected]>
---
M src/arch/arm/self_debug.cc
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/src/arch/arm/self_debug.cc b/src/arch/arm/self_debug.cc
index 96c7822..c964b11 100644
--- a/src/arch/arm/self_debug.cc
+++ b/src/arch/arm/self_debug.cc
@@ -429,7 +429,7 @@
             break;
         case EL2:
             v = (ssc == 0x3) ||
-                ((hmc == 0x1) && !((ssc==0x2) && (pmc = 0x0)));
+                ((hmc == 0x1) && !((ssc==0x2) && (pmc == 0x0)));
             if (v && pmc == 0x2)
                 panic("Unexpected EL in SelfDebug::isDebugEnabled.\n");
             break;

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/31080
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ibf5a0006bce79b67d662fd1f8942699582956d58
Gerrit-Change-Number: 31080
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to