Hsuan Hsu has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/30917 )
Change subject: cpu-kvm: Initialize _hasKernelIRQChip in the constructor
......................................................................
cpu-kvm: Initialize _hasKernelIRQChip in the constructor
This class member was only correctly set to true when using an in-kernel
interrupt controller, but was un-initialized when trying to use a user-
space one and would cause trouble.
JIRA: https://gem5.atlassian.net/browse/GEM5-663
Change-Id: I71b052c6da7e8790b05a15c07e7933bc4f912785
Signed-off-by: Hsuan Hsu <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/30917
Reviewed-by: Giacomo Travaglini <[email protected]>
Reviewed-by: Andreas Sandberg <[email protected]>
Maintainer: Giacomo Travaglini <[email protected]>
Maintainer: Andreas Sandberg <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/cpu/kvm/vm.cc
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/cpu/kvm/vm.cc b/src/cpu/kvm/vm.cc
index 720548c..4640ca1 100644
--- a/src/cpu/kvm/vm.cc
+++ b/src/cpu/kvm/vm.cc
@@ -294,6 +294,7 @@
kvm(new Kvm()), system(nullptr),
vmFD(kvm->createVM()),
started(false),
+ _hasKernelIRQChip(false),
nextVCPUID(0)
{
maxMemorySlot = kvm->capNumMemSlots();
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/30917
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I71b052c6da7e8790b05a15c07e7933bc4f912785
Gerrit-Change-Number: 30917
Gerrit-PatchSet: 8
Gerrit-Owner: Hsuan Hsu <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Hsuan Hsu <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
