Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/31176 )
Change subject: dev-arm: Avoid code duplication in Pl111
......................................................................
dev-arm: Avoid code duplication in Pl111
Change-Id: I17af93459ace0e4ef82693622a4135c3e831aaf5
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/31176
Reviewed-by: Bobby R. Bruce <[email protected]>
Reviewed-by: Andreas Sandberg <[email protected]>
Maintainer: Andreas Sandberg <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/dev/arm/pl111.cc
1 file changed, 2 insertions(+), 31 deletions(-)
Approvals:
Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
Bobby R. Bruce: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/dev/arm/pl111.cc b/src/dev/arm/pl111.cc
index 27606e1..111de03 100644
--- a/src/dev/arm/pl111.cc
+++ b/src/dev/arm/pl111.cc
@@ -203,21 +203,7 @@
}
}
- switch(pkt->getSize()) {
- case 1:
- pkt->setLE<uint8_t>(data);
- break;
- case 2:
- pkt->setLE<uint16_t>(data);
- break;
- case 4:
- pkt->setLE<uint32_t>(data);
- break;
- default:
- panic("CLCD controller read size too big?\n");
- break;
- }
-
+ pkt->setUintX(data, LittleEndianByteOrder);
pkt->makeAtomicResponse();
return pioDelay;
}
@@ -229,22 +215,7 @@
// use a temporary data since the LCD registers are read/written with
// different size operations
//
- uint32_t data = 0;
-
- switch(pkt->getSize()) {
- case 1:
- data = pkt->getLE<uint8_t>();
- break;
- case 2:
- data = pkt->getLE<uint16_t>();
- break;
- case 4:
- data = pkt->getLE<uint32_t>();
- break;
- default:
- panic("PL111 CLCD controller write size too big?\n");
- break;
- }
+ const uint32_t data = pkt->getUintX(LittleEndianByteOrder);
assert(pkt->getAddr() >= pioAddr &&
pkt->getAddr() < pioAddr + pioSize);
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/31176
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I17af93459ace0e4ef82693622a4135c3e831aaf5
Gerrit-Change-Number: 31176
Gerrit-PatchSet: 3
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
