Hoa Nguyen has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/32095 )
Change subject: cpu-kvm: Add missing 'override' keyword
......................................................................
cpu-kvm: Add missing 'override' keyword
clang requires all functions that override a member function to be
masked by the 'override' keyword. The missing 'override' in
timer.hh causes compiling issues while compiling gem5 with clang.
This commit adds the missing keyword.
Jira: https://gem5.atlassian.net/browse/GEM5-724
Change-Id: I3b5c7af666927b079a785803c8bb4869180ff777
Signed-off-by: Hoa Nguyen <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/32095
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/cpu/kvm/timer.hh
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/cpu/kvm/timer.hh b/src/cpu/kvm/timer.hh
index 376ba7c..7daa3cd 100644
--- a/src/cpu/kvm/timer.hh
+++ b/src/cpu/kvm/timer.hh
@@ -194,12 +194,12 @@
float hostFactor, Tick hostFreq);
~PosixKvmTimer();
- void arm(Tick ticks);
- void disarm();
+ void arm(Tick ticks) override;
+ void disarm() override;
bool expired() override;
protected:
- Tick calcResolution();
+ Tick calcResolution() override;
private:
clockid_t clockID;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/32095
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I3b5c7af666927b079a785803c8bb4869180ff777
Gerrit-Change-Number: 32095
Gerrit-PatchSet: 3
Gerrit-Owner: Hoa Nguyen <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Hoa Nguyen <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
