Srikant Bharadwaj has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/32300 )
Change subject: mem-garnet: Improve debug messages within Garnet
......................................................................
mem-garnet: Improve debug messages within Garnet
This patch clears up some redundant debug messages and adds
some more clarity in existing logs.
Change-Id: I5d351e5a1d64234cc3880b59b1d5992f91b579f2
---
M src/mem/ruby/network/garnet2.0/NetworkInterface.cc
M src/mem/ruby/network/garnet2.0/NetworkLink.cc
M src/mem/ruby/network/garnet2.0/Router.cc
3 files changed, 5 insertions(+), 16 deletions(-)
diff --git a/src/mem/ruby/network/garnet2.0/NetworkInterface.cc
b/src/mem/ruby/network/garnet2.0/NetworkInterface.cc
index 81c062f..85a161c 100644
--- a/src/mem/ruby/network/garnet2.0/NetworkInterface.cc
+++ b/src/mem/ruby/network/garnet2.0/NetworkInterface.cc
@@ -223,11 +223,9 @@
bool messageEnqueuedThisCycle = checkStallQueue();
/*********** Check the incoming flit link **********/
- DPRINTF(RubyNetwork, "Number of iPorts: %d\n", inPorts.size());
+ DPRINTF(RubyNetwork, "Number of input ports: %d\n", inPorts.size());
for (auto &iPort: inPorts) {
NetworkLink *inNetLink = iPort->inNetLink();
- DPRINTF(RubyNetwork, "Checking input port:%s with vnets %s\n",
- inNetLink->name(), iPort->printVnets());
if (inNetLink->isReady(curTick())) {
flit *t_flit = inNetLink->consumeLink();
DPRINTF(RubyNetwork, "Recieved flit:%s\n", *t_flit);
@@ -286,8 +284,6 @@
for (auto &oPort: outPorts) {
CreditLink *inCreditLink = oPort->inCreditLink();
- DPRINTF(RubyNetwork, "Checking input port:%s with vnets %s\n",
- inCreditLink->name(), oPort->printVnets());
if (inCreditLink->isReady(curTick())) {
Credit *t_credit = (Credit*) inCreditLink->consumeLink();
outVcState[t_credit->get_vc()].increment_credit();
@@ -306,7 +302,8 @@
// back.
for (auto &iPort: inPorts) {
if (iPort->outCreditQueue()->getSize() > 0) {
- DPRINTF(RubyNetwork, "Sending a credit via %s at %ld\n",
+ DPRINTF(RubyNetwork, "Sending a credit %s via %s at %ld\n",
+ *(iPort->outCreditQueue()->peekTopFlit()),
iPort->outCreditLink()->name(), clockEdge(Cycles(1)));
iPort->outCreditLink()->
scheduleEventAbsolute(clockEdge(Cycles(1)));
diff --git a/src/mem/ruby/network/garnet2.0/NetworkLink.cc
b/src/mem/ruby/network/garnet2.0/NetworkLink.cc
index 11ac4cb..cb00943 100644
--- a/src/mem/ruby/network/garnet2.0/NetworkLink.cc
+++ b/src/mem/ruby/network/garnet2.0/NetworkLink.cc
@@ -78,10 +78,10 @@
assert(curTick() == clockEdge());
if (link_srcQueue->isReady(curTick())) {
flit *t_flit = link_srcQueue->getTopFlit();
+ DPRINTF(RubyNetwork, "Transmission will finish at %ld :%s\n",
+ clockEdge(m_latency), *t_flit);
if (m_type != NUM_LINK_TYPES_) {
// Only for assertions and debug messages
- DPRINTF(RubyNetwork, "Transmitting at %ld :%s\n",
- clockEdge(m_latency), *t_flit);
assert(t_flit->m_width == bitWidth);
assert((std::find(mVnets.begin(), mVnets.end(),
t_flit->get_vnet()) != mVnets.end()) ||
diff --git a/src/mem/ruby/network/garnet2.0/Router.cc
b/src/mem/ruby/network/garnet2.0/Router.cc
index 523680e..9802b69 100644
--- a/src/mem/ruby/network/garnet2.0/Router.cc
+++ b/src/mem/ruby/network/garnet2.0/Router.cc
@@ -93,9 +93,6 @@
Router::addInPort(PortDirection inport_dirn,
NetworkLink *in_link, CreditLink *credit_link)
{
- DPRINTF(RubyNetwork, "%d == %d? %s\n", in_link->bitWidth,
- m_bit_width, in_link->name());
-
fatal_if(in_link->bitWidth != m_bit_width, "Widths of link %s(%d)does"
" not match that of Router%d(%d). Consider inserting SerDes "
"Units.", in_link->name(), in_link->bitWidth, m_id,
m_bit_width);
@@ -121,11 +118,6 @@
std::vector<NetDest>& routing_table_entry, int
link_weight,
CreditLink *credit_link, uint32_t consumerVcs)
{
- DPRINTF(RubyNetwork, "%d == %d? %s\n", out_link->bitWidth,
- m_bit_width, out_link->name());
- DPRINTF(RubyNetwork, "Consumer %s VC: %d\n", out_link->name(),
- consumerVcs);
-
fatal_if(out_link->bitWidth != m_bit_width, "Widths of units do not
match."
" Consider inserting SerDes Units");
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/32300
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: feature-heterogarnet
Gerrit-Change-Id: I5d351e5a1d64234cc3880b59b1d5992f91b579f2
Gerrit-Change-Number: 32300
Gerrit-PatchSet: 1
Gerrit-Owner: Srikant Bharadwaj <srikant.bharad...@amd.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
