Hello Nikos Nikoleris,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/32639
to review the following change.
Change subject: arch-arm: Use isSecure variable for Stage2Lookup
......................................................................
arch-arm: Use isSecure variable for Stage2Lookup
TLB entries are tagged with the security state of the cpu instead
of the security attribute of the physical address
Change-Id: I728ba1c841de1ec6c1ee03aee012b185c968d078
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-by: Nikos Nikoleris <[email protected]>
---
M src/arch/arm/tlb.cc
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/arch/arm/tlb.cc b/src/arch/arm/tlb.cc
index dc4296d..e8bb718 100644
--- a/src/arch/arm/tlb.cc
+++ b/src/arch/arm/tlb.cc
@@ -1655,7 +1655,7 @@
fault = checkPermissions(s1Te, req, mode);
if (stage2Req & (fault == NoFault)) {
Stage2LookUp *s2Lookup = new Stage2LookUp(this, stage2Tlb,
*s1Te,
- req, translation, mode, timing, functional, !(s1Te->ns),
+ req, translation, mode, timing, functional, isSecure,
curTranType);
fault = s2Lookup->getTe(tc, mergeTe);
if (s2Lookup->isComplete()) {
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/32639
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I728ba1c841de1ec6c1ee03aee012b185c968d078
Gerrit-Change-Number: 32639
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
