Kyle Roarty has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/32654 )
Change subject: configs: Remove unneeded variable assignments in apu_se
......................................................................
configs: Remove unneeded variable assignments in apu_se
This patch removes:
A line assigning a variable to itself
An assignment to a variable (chroot) that is never used.
The above assignment also caused an error, "'NoneType' object
has no attribute 'startswith'"
Change-Id: Ib93c25fee4a0f7c1440de8067b086d8b96614796
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/32654
Reviewed-by: Matt Sinclair <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M configs/example/apu_se.py
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
Matt Sinclair: Looks good to me, but someone else must approve
kokoro: Regressions pass
diff --git a/configs/example/apu_se.py b/configs/example/apu_se.py
index fcec7c1..25c148e 100644
--- a/configs/example/apu_se.py
+++ b/configs/example/apu_se.py
@@ -334,8 +334,6 @@
shader.CUs = compute_units
########################## Creating the CPU system ########################
-options.num_cpus = options.num_cpus
-
# The shader core will be whatever is after the CPU cores are accounted for
shader_idx = options.num_cpus
@@ -616,7 +614,6 @@
########################## Start simulation ########################
-chroot = os.path.expanduser(options.chroot)
redirect_paths = [RedirectPath(src = "/proc",
dests = ["%s/fs/proc" % m5.options.outdir]),
RedirectPath(src = "/sys",
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/32654
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib93c25fee4a0f7c1440de8067b086d8b96614796
Gerrit-Change-Number: 32654
Gerrit-PatchSet: 2
Gerrit-Owner: Kyle Roarty <[email protected]>
Gerrit-Reviewer: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Kyle Roarty <[email protected]>
Gerrit-Reviewer: Matt Sinclair <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-CC: Bradford Beckmann <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
