Hello Nikos Nikoleris,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/32774
to review the following change.
Change subject: arch-arm: Remove setters from SoftwareStep
......................................................................
arch-arm: Remove setters from SoftwareStep
Change-Id: Ib945b1aa46742b90062ce7a5de563f164127075f
Signed-off-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Reviewed-by: Nikos Nikoleris <nikos.nikole...@arm.com>
---
M src/arch/arm/self_debug.hh
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/src/arch/arm/self_debug.hh b/src/arch/arm/self_debug.hh
index 7a96d42..c9afa60 100644
--- a/src/arch/arm/self_debug.hh
+++ b/src/arch/arm/self_debug.hh
@@ -204,6 +204,8 @@
bool cpsrD;
public:
+ friend class SelfDebug;
+
SoftwareStep(SelfDebug *s)
: bSS(false), stateSS(INACTIVE_STATE),
conf(s), steppedLdx(false)
@@ -213,18 +215,6 @@
ExceptionLevel dest);
bool advanceSS(ThreadContext *tc);
- inline void
- setCPSRD(bool val)
- {
- cpsrD = val;
- }
-
- inline void
- setEnableSS(bool val)
- {
- bSS = val;
- }
-
void
setLdx()
{
@@ -391,7 +381,7 @@
{
enableFlag = bits(val, 15);
bKDE = bits(val, 13);
- softStep->setEnableSS((bool)bits(val, 0));
+ softStep->bSS = bits(val, 0);
}
inline void
@@ -427,7 +417,7 @@
inline void
setDebugMask(bool mask)
{
- softStep->setCPSRD(mask);
+ softStep->cpsrD = mask;
}
inline bool
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/32774
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib945b1aa46742b90062ce7a5de563f164127075f
Gerrit-Change-Number: 32774
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Nikos Nikoleris <nikos.nikole...@arm.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
