Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/32900 )
Change subject: cpu: Don't construct and then copy the decoder in
SimpleThread.
......................................................................
cpu: Don't construct and then copy the decoder in SimpleThread.
The SimpleThread constructor was constructing a temporary copy of the
decoder, and then copying it into it's local version. This copy is a
waste, and also requires there to be a copy operator for the Decoder.
Change-Id: I1123b4ec767e08ceb2f108b3a6b19ca18d7c677c
---
M src/cpu/simple_thread.cc
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/cpu/simple_thread.cc b/src/cpu/simple_thread.cc
index 1d2c0b8..7ed2e82 100644
--- a/src/cpu/simple_thread.cc
+++ b/src/cpu/simple_thread.cc
@@ -72,7 +72,7 @@
isa(dynamic_cast<TheISA::ISA *>(_isa)),
predicate(true), memAccPredicate(true),
comInstEventQueue("instruction-based event queue"),
- system(_sys), itb(_itb), dtb(_dtb), decoder(TheISA::Decoder(isa))
+ system(_sys), itb(_itb), dtb(_dtb), decoder(isa)
{
assert(isa);
clearArchRegs();
@@ -84,7 +84,7 @@
isa(dynamic_cast<TheISA::ISA *>(_isa)),
predicate(true), memAccPredicate(true),
comInstEventQueue("instruction-based event queue"),
- system(_sys), itb(_itb), dtb(_dtb), decoder(TheISA::Decoder(isa))
+ system(_sys), itb(_itb), dtb(_dtb), decoder(isa)
{
assert(isa);
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/32900
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I1123b4ec767e08ceb2f108b3a6b19ca18d7c677c
Gerrit-Change-Number: 32900
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
