Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/32896 )
Change subject: x86: Fix some style issues in the microcode ROM class.
......................................................................
x86: Fix some style issues in the microcode ROM class.
Change-Id: I64fb5efbc9f63298c103816503f4718308032eb4
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/32896
Reviewed-by: Andreas Sandberg <[email protected]>
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/x86/microcode_rom.hh
1 file changed, 34 insertions(+), 29 deletions(-)
Approvals:
Andreas Sandberg: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/x86/microcode_rom.hh b/src/arch/x86/microcode_rom.hh
index ad7bb99..4f7952a 100644
--- a/src/arch/x86/microcode_rom.hh
+++ b/src/arch/x86/microcode_rom.hh
@@ -35,41 +35,46 @@
namespace X86ISAInst
{
- class MicrocodeRom
+
+class MicrocodeRom
+{
+ protected:
+
+ typedef StaticInstPtr (*GenFunc)(StaticInstPtr);
+
+ static const MicroPC numMicroops;
+
+ GenFunc *genFuncs;
+
+ public:
+ //Constructor.
+ MicrocodeRom();
+
+ //Destructor.
+ ~MicrocodeRom()
{
- protected:
+ delete [] genFuncs;
+ }
- typedef StaticInstPtr (*GenFunc)(StaticInstPtr);
+ StaticInstPtr
+ fetchMicroop(MicroPC microPC, StaticInstPtr curMacroop)
+ {
+ microPC = normalMicroPC(microPC);
+ if (microPC >= numMicroops)
+ return X86ISA::badMicroop;
+ else
+ return genFuncs[microPC](curMacroop);
+ }
+};
- static const MicroPC numMicroops;
-
- GenFunc * genFuncs;
-
- public:
- //Constructor.
- MicrocodeRom();
-
- //Destructor.
- ~MicrocodeRom()
- {
- delete [] genFuncs;
- }
-
- StaticInstPtr
- fetchMicroop(MicroPC microPC, StaticInstPtr curMacroop)
- {
- microPC = normalMicroPC(microPC);
- if (microPC >= numMicroops)
- return X86ISA::badMicroop;
- else
- return genFuncs[microPC](curMacroop);
- }
- };
-}
+} // namespace X86ISAInst
namespace X86ISA
{
- using X86ISAInst::MicrocodeRom;
+
+using X86ISAInst::MicrocodeRom;
+
}
+
#endif // __ARCH_X86_MICROCODE_ROM_HH__
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/32896
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I64fb5efbc9f63298c103816503f4718308032eb4
Gerrit-Change-Number: 32896
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Brandon Potter <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
