Bobby R. Bruce has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/33139 )

Change subject: tests: Removed the ignoring of tests
......................................................................

tests: Removed the ignoring of tests

This commit reverts
https://gem5-review.googlesource.com/c/public/gem5/+/23023.

It has proven to be an unpopular piece of functionality which makes it
too easy to silently ignore failing tests. The new policy will be to
remove/comment-out failing tests in the testing source and tag with Jira
issues as to why.

Change-Id: I17d69fc57a9171ce3702e019615390a9aa3da250
---
M tests/gem5/suite.py
1 file changed, 0 insertions(+), 14 deletions(-)



diff --git a/tests/gem5/suite.py b/tests/gem5/suite.py
index 329e31f..cba3d43 100644
--- a/tests/gem5/suite.py
+++ b/tests/gem5/suite.py
@@ -88,15 +88,6 @@
     fixtures = list(fixtures)
     testsuites = []

-    # Obtain the set of tests to ignore. This is found in the
-    # ".testignore" file.
-    __location__ = os.path.realpath(
-        os.path.join(os.getcwd(), os.path.dirname(__file__)))
-    _test_ignore_file_loc = os.path.join(__location__,".testignore")
-    ignore = set()
-    if os.path.exists(_test_ignore_file_loc):
-        ignore.update(open(_test_ignore_file_loc).read().splitlines())
-
     for host in valid_hosts:
         for opt in valid_variants:
             for isa in valid_isas:
@@ -115,11 +106,6 @@
                 if protocol:
                     _name += '-'+protocol

- # We check to see if this test suite is to be ignored. If so,
-                # we skip it.
-                if _name in ignore:
-                    continue
-
# Create the running of gem5 subtest. NOTE: We specifically
                 # create this test before our verifiers so this is listed
                 # first.

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/33139
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I17d69fc57a9171ce3702e019615390a9aa3da250
Gerrit-Change-Number: 33139
Gerrit-PatchSet: 1
Gerrit-Owner: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to