Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/32926 )
Change subject: mem: Use getGuestByteOrder in the indirect memory
prefetcher.
......................................................................
mem: Use getGuestByteOrder in the indirect memory prefetcher.
Use that instead of accessing TheISA::GuestByteOrder directly.
Change-Id: I6fbeb7501aceadb95739bb482215097af18da2fa
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/32926
Reviewed-by: Daniel Carvalho <[email protected]>
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/mem/cache/prefetch/indirect_memory.cc
1 file changed, 1 insertion(+), 8 deletions(-)
Approvals:
Daniel Carvalho: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/mem/cache/prefetch/indirect_memory.cc
b/src/mem/cache/prefetch/indirect_memory.cc
index ac825fd..f6f0354 100644
--- a/src/mem/cache/prefetch/indirect_memory.cc
+++ b/src/mem/cache/prefetch/indirect_memory.cc
@@ -46,15 +46,8 @@
ipd(p->ipd_table_assoc, p->ipd_table_entries,
p->ipd_table_indexing_policy,
p->ipd_table_replacement_policy,
IndirectPatternDetectorEntry(p->addr_array_len,
shiftValues.size())),
- ipdEntryTrackingMisses(nullptr),
-#if THE_ISA != NULL_ISA
- byteOrder(TheISA::GuestByteOrder)
-#else
- byteOrder((ByteOrder) -1)
-#endif
+ ipdEntryTrackingMisses(nullptr), byteOrder(p->sys->getGuestByteOrder())
{
- fatal_if(byteOrder == static_cast<ByteOrder>(-1),
- "This prefetcher requires a defined ISA\n");
}
void
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/32926
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I6fbeb7501aceadb95739bb482215097af18da2fa
Gerrit-Change-Number: 32926
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Javier Bueno Hedo <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-CC: Andreas Sandberg <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
