[gem5-dev] Change in gem5/gem5[develop]: sim: Style fixes in the base Fault classes.

[Gabe Black (Gerrit) via gem5-dev]

Gabe Black has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/33280 )

Change subject: sim: Style fixes in the base Fault classes.
......................................................................

sim: Style fixes in the base Fault classes.

Change-Id: Iff8588aba929b3909ca1b5ec0e494acb8f838543
---
M src/sim/faults.cc
M src/sim/faults.hh
2 files changed, 31 insertions(+), 30 deletions(-)



diff --git a/src/sim/faults.cc b/src/sim/faults.cc
index c2ce978..46485d4 100644
--- a/src/sim/faults.cc
+++ b/src/sim/faults.cc
@@ -37,43 +37,47 @@
 #include "sim/full_system.hh"
 #include "sim/process.hh"

-void FaultBase::invoke(ThreadContext * tc, const StaticInstPtr &inst)
+void
+FaultBase::invoke(ThreadContext *tc, const StaticInstPtr &inst)
 {
-    if (FullSystem) {
-        DPRINTF(Fault, "Fault %s at PC: %s\n", name(), tc->pcState());
-    } else {
-        panic("fault (%s) detected @ PC %s", name(), tc->pcState());
-    }
+    panic_if(!FullSystem, "fault (%s) detected @ PC %s",
+             name(), tc->pcState());
+    DPRINTF(Fault, "Fault %s at PC: %s\n", name(), tc->pcState());
 }

-void UnimpFault::invoke(ThreadContext * tc, const StaticInstPtr &inst)
+void
+UnimpFault::invoke(ThreadContext *tc, const StaticInstPtr &inst)
 {
-    panic("Unimpfault: %s\n", panicStr.c_str());
+    panic("Unimpfault: %s", panicStr.c_str());
 }

-void ReExec::invoke(ThreadContext *tc, const StaticInstPtr &inst)
+void
+ReExec::invoke(ThreadContext *tc, const StaticInstPtr &inst)
 {
     tc->pcState(tc->pcState());
 }

-void SyscallRetryFault::invoke(ThreadContext *tc, const StaticInstPtr  
&inst)
+void
+SyscallRetryFault::invoke(ThreadContext *tc, const StaticInstPtr &inst)
 {
     tc->pcState(tc->pcState());
 }

-void GenericPageTableFault::invoke(ThreadContext *tc, const StaticInstPtr  
&inst)
+void
+GenericPageTableFault::invoke(ThreadContext *tc, const StaticInstPtr &inst)
 {
     bool handled = false;
     if (!FullSystem) {
         Process *p = tc->getProcessPtr();
         handled = p->fixupFault(vaddr);
     }
-    if (!handled)
-        panic("Page table fault when accessing virtual address %#x\n",  
vaddr);
+    panic_if(!handled, "Page table fault when accessing virtual  
address %#x",
+             vaddr);

 }

-void GenericAlignmentFault::invoke(ThreadContext *tc, const StaticInstPtr  
&inst)
+void
+GenericAlignmentFault::invoke(ThreadContext *tc, const StaticInstPtr &inst)
 {
     panic("Alignment fault when accessing virtual address %#x\n", vaddr);
 }
diff --git a/src/sim/faults.hh b/src/sim/faults.hh
index 646d24a..e9a57c6 100644
--- a/src/sim/faults.hh
+++ b/src/sim/faults.hh
@@ -35,14 +35,14 @@

 class ThreadContext;

-typedef const char * FaultName;
+typedef const char *FaultName;
 typedef Stats::Scalar FaultStat;

 class FaultBase
 {
   public:
     virtual FaultName name() const = 0;
-    virtual void invoke(ThreadContext * tc, const StaticInstPtr &inst =
+    virtual void invoke(ThreadContext * tc, const StaticInstPtr &inst=
                         StaticInst::nullStaticInstPtr);

     virtual ~FaultBase() {};
@@ -53,22 +53,19 @@
   private:
     std::string panicStr;
   public:
-    UnimpFault(std::string _str)
-        : panicStr(_str)
-    { }
+    UnimpFault(std::string _str) : panicStr(_str) {}

     FaultName name() const { return "Unimplemented simulator feature"; }
-    void invoke(ThreadContext * tc, const StaticInstPtr &inst =
-                StaticInst::nullStaticInstPtr);
+    void invoke(ThreadContext *tc, const StaticInstPtr &inst =
+                StaticInst::nullStaticInstPtr) override;
 };

 class ReExec : public FaultBase
 {
   public:
     virtual FaultName name() const { return "Re-execution fault"; }
-    ReExec() {}
-    void invoke(ThreadContext *tc, const StaticInstPtr &inst =
-                StaticInst::nullStaticInstPtr);
+    void invoke(ThreadContext *tc, const StaticInstPtr &inst=
+                StaticInst::nullStaticInstPtr) override;
 };

 /*
@@ -83,8 +80,8 @@
   public:
     virtual FaultName name() const { return "System call retry fault"; }
     SyscallRetryFault() {}
-    void invoke(ThreadContext *tc, const StaticInstPtr &inst =
-                StaticInst::nullStaticInstPtr);
+    void invoke(ThreadContext *tc, const StaticInstPtr &inst=
+                StaticInst::nullStaticInstPtr) override;
 };

 class GenericPageTableFault : public FaultBase
@@ -94,8 +91,8 @@
   public:
     FaultName name() const { return "Generic page table fault"; }
     GenericPageTableFault(Addr va) : vaddr(va) {}
-    void invoke(ThreadContext * tc, const StaticInstPtr &inst =
-                StaticInst::nullStaticInstPtr);
+    void invoke(ThreadContext *tc, const StaticInstPtr &inst=
+                StaticInst::nullStaticInstPtr) override;
     Addr getFaultVAddr() const { return vaddr; }
 };

@@ -106,8 +103,8 @@
   public:
     FaultName name() const { return "Generic alignment fault"; }
     GenericAlignmentFault(Addr va) : vaddr(va) {}
-    void invoke(ThreadContext * tc, const StaticInstPtr &inst =
-                StaticInst::nullStaticInstPtr);
+    void invoke(ThreadContext *tc, const StaticInstPtr &inst=
+                StaticInst::nullStaticInstPtr) override;
     Addr getFaultVAddr() const { return vaddr; }
 };


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/33280
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iff8588aba929b3909ca1b5ec0e494acb8f838543
Gerrit-Change-Number: 33280
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabebl...@google.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s