Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/33202 )
Change subject: arch: Get rid of (some) unused VAddr types.
......................................................................
arch: Get rid of (some) unused VAddr types.
X86 actually defines and uses a VAddr bitunion, but the ARM, MIPS and
SPARC versions are just stubs and aren't used anywhere.
Change-Id: Iea8d0c8ab04ac1d95f49458f0fc41f291751da1a
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/33202
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
Reviewed-by: Nikos Nikoleris <[email protected]>
---
M src/arch/arm/pagetable.hh
M src/arch/mips/pagetable.hh
M src/arch/sparc/pagetable.hh
3 files changed, 1 insertion(+), 15 deletions(-)
Approvals:
Nikos Nikoleris: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/arm/pagetable.hh b/src/arch/arm/pagetable.hh
index b91d3de..054b6f5 100644
--- a/src/arch/arm/pagetable.hh
+++ b/src/arch/arm/pagetable.hh
@@ -49,12 +49,6 @@
namespace ArmISA {
-struct VAddr
-{
- VAddr(Addr a) { panic("not implemented yet."); }
-};
-
-
// ITB/DTB page table entry
struct PTE
{
diff --git a/src/arch/mips/pagetable.hh b/src/arch/mips/pagetable.hh
index 648b205..26c8485 100644
--- a/src/arch/mips/pagetable.hh
+++ b/src/arch/mips/pagetable.hh
@@ -36,10 +36,6 @@
namespace MipsISA {
-struct VAddr
-{
-};
-
// ITB/DTB page table entry
struct PTE
{
diff --git a/src/arch/sparc/pagetable.hh b/src/arch/sparc/pagetable.hh
index b17b65f..73435c0 100644
--- a/src/arch/sparc/pagetable.hh
+++ b/src/arch/sparc/pagetable.hh
@@ -37,12 +37,8 @@
class Checkpoint;
-namespace SparcISA {
-
-struct VAddr
+namespace SparcISA
{
- VAddr(Addr a) { panic("not implemented yet."); }
-};
class TteTag
{
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/33202
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iea8d0c8ab04ac1d95f49458f0fc41f291751da1a
Gerrit-Change-Number: 33202
Gerrit-PatchSet: 4
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
