Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/33201 )
Change subject: sparc: Minor cleanup in isa_traits.hh.
......................................................................
sparc: Minor cleanup in isa_traits.hh.
Remove unnecessary includes, and an unnecessary/unimplemented function
prototype.
Change-Id: I2230c1ec62734d918f0f6af6f4c1e1a64f25f812
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/33201
Reviewed-by: Gabe Black <[email protected]>
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/sparc/isa_traits.hh
M src/arch/sparc/pagetable.hh
2 files changed, 1 insertion(+), 7 deletions(-)
Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/sparc/isa_traits.hh b/src/arch/sparc/isa_traits.hh
index ad9cf08..e1917f9 100644
--- a/src/arch/sparc/isa_traits.hh
+++ b/src/arch/sparc/isa_traits.hh
@@ -29,10 +29,7 @@
#ifndef __ARCH_SPARC_ISA_TRAITS_HH__
#define __ARCH_SPARC_ISA_TRAITS_HH__
-#include "arch/sparc/sparc_traits.hh"
-#include "arch/sparc/types.hh"
#include "base/types.hh"
-#include "cpu/static_inst_fwd.hh"
namespace SparcISA
{
@@ -42,8 +39,6 @@
const Addr PageShift = 13;
const Addr PageBytes = ULL(1) << PageShift;
-StaticInstPtr decodeInst(ExtMachInst);
-
}
#endif // __ARCH_SPARC_ISA_TRAITS_HH__
diff --git a/src/arch/sparc/pagetable.hh b/src/arch/sparc/pagetable.hh
index 73435c0..8bf8176 100644
--- a/src/arch/sparc/pagetable.hh
+++ b/src/arch/sparc/pagetable.hh
@@ -34,8 +34,7 @@
#include "arch/sparc/isa_traits.hh"
#include "base/bitfield.hh"
#include "base/logging.hh"
-
-class Checkpoint;
+#include "sim/serialize.hh"
namespace SparcISA
{
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/33201
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I2230c1ec62734d918f0f6af6f4c1e1a64f25f812
Gerrit-Change-Number: 33201
Gerrit-PatchSet: 4
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
