Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/33740 )

Change subject: mips,cpu: Get rid of the IsDpsOp StaticInst flag.
......................................................................

mips,cpu: Get rid of the IsDpsOp StaticInst flag.

This flag was set by MIPS for a few instructions, but didn't have an
accessor in StaticInst and was never used for anything.

Change-Id: I153cedde0d16cb1d78b2705bd7340ebfd10e4fb6
---
M src/arch/mips/isa/formats/dsp.isa
M src/cpu/StaticInstFlags.py
2 files changed, 1 insertion(+), 5 deletions(-)



diff --git a/src/arch/mips/isa/formats/dsp.isa b/src/arch/mips/isa/formats/dsp.isa
index 9a6d614..12af2d6 100644
--- a/src/arch/mips/isa/formats/dsp.isa
+++ b/src/arch/mips/isa/formats/dsp.isa
@@ -173,8 +173,6 @@

     code = decl_code + code + write_code

-    opt_flags += ('IsDspOp',)
-
     iop = InstObjParams(name, Name, 'DspIntOp', code, opt_flags)
     header_output = BasicDeclare.subst(iop)
     decoder_output = BasicConstructor.subst(iop)
@@ -204,8 +202,6 @@

     code = decl_code + fetch_code + code + write_code

-    opt_flags += ('IsDspOp',)
-
     iop = InstObjParams(name, Name, 'DspHiLoOp', code, opt_flags)
     header_output = BasicDeclare.subst(iop)
     decoder_output = BasicConstructor.subst(iop)
diff --git a/src/cpu/StaticInstFlags.py b/src/cpu/StaticInstFlags.py
index b4ef71b..9fa8b28 100644
--- a/src/cpu/StaticInstFlags.py
+++ b/src/cpu/StaticInstFlags.py
@@ -100,6 +100,6 @@
         # This flag doesn't do anything yet
'IsMicroBranch', # This microop branches within the microcode for
                             # a macroop
-        'IsDspOp',
+
         'IsSquashAfter'     # Squash all uncommitted state after executed
         ]

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/33740
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I153cedde0d16cb1d78b2705bd7340ebfd10e4fb6
Gerrit-Change-Number: 33740
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to