Daniel Carvalho has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/33386 )
Change subject: mem-cache: Explicitly define threshold of BDI's
sub-compressors
......................................................................
mem-cache: Explicitly define threshold of BDI's sub-compressors
Allow all sub-compressors of BDI to be successful as long as
they are able to compress. Then, BDI's actual size threshold
acts as the cutting point.
This situation arises on any multi compressor; yet, generalizing
this assumption might be too bold.
Change-Id: Iec5057d16d4a7ba5fb573133a30ea10869bd67e0
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/33386
Reviewed-by: Nikos Nikoleris <[email protected]>
Maintainer: Nikos Nikoleris <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/mem/cache/compressors/Compressors.py
1 file changed, 10 insertions(+), 3 deletions(-)
Approvals:
Nikos Nikoleris: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/mem/cache/compressors/Compressors.py
b/src/mem/cache/compressors/Compressors.py
index 9fa06f2..2497e82 100644
--- a/src/mem/cache/compressors/Compressors.py
+++ b/src/mem/cache/compressors/Compressors.py
@@ -148,6 +148,13 @@
class BDI(MultiCompressor):
encoding_in_tags=True
- compressors = [ZeroCompressor(), RepeatedQwordsCompressor(),
- Base64Delta8(), Base64Delta16(), Base64Delta32(), Base32Delta8(),
- Base32Delta16(), Base16Delta8()]
+ compressors = [
+ ZeroCompressor(size_threshold_percentage=99),
+ RepeatedQwordsCompressor(size_threshold_percentage=99),
+ Base64Delta8(size_threshold_percentage=99),
+ Base64Delta16(size_threshold_percentage=99),
+ Base64Delta32(size_threshold_percentage=99),
+ Base32Delta8(size_threshold_percentage=99),
+ Base32Delta16(size_threshold_percentage=99),
+ Base16Delta8(size_threshold_percentage=99),
+ ]
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/33386
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iec5057d16d4a7ba5fb573133a30ea10869bd67e0
Gerrit-Change-Number: 33386
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
