Sampad Mohapatra has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/33755 )
Change subject: mem-ruby: Change request to response in
MOESI_AMD_Base-dir.sm
......................................................................
mem-ruby: Change request to response in MOESI_AMD_Base-dir.sm
The responseToDMA MessageBuffer in MOESI_AMD_Base-dir.sm
transmits both data and acks, but it's vnet_type is currently
set as request. This should be changed to response.
Signed-off-by: Sampad Mohapatra <[email protected]>
Change-Id: I0eb9e8fc8e25111849605a710a5150ce5fc3b83b
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/33755
Reviewed-by: Jason Lowe-Power <[email protected]>
Reviewed-by: Srikant Bharadwaj <[email protected]>
Reviewed-by: Matt Sinclair <[email protected]>
Maintainer: Matt Sinclair <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/mem/ruby/protocol/MOESI_AMD_Base-dir.sm
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved
Matt Sinclair: Looks good to me, but someone else must approve; Looks
good to me, approved
Srikant Bharadwaj: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/mem/ruby/protocol/MOESI_AMD_Base-dir.sm
b/src/mem/ruby/protocol/MOESI_AMD_Base-dir.sm
index f1bc637..3e84ba6 100644
--- a/src/mem/ruby/protocol/MOESI_AMD_Base-dir.sm
+++ b/src/mem/ruby/protocol/MOESI_AMD_Base-dir.sm
@@ -44,7 +44,7 @@
// DMA
MessageBuffer * requestFromDMA, network="From", virtual_network="1",
vnet_type="request";
- MessageBuffer * responseToDMA, network="To", virtual_network="3",
vnet_type="request";
+ MessageBuffer * responseToDMA, network="To", virtual_network="3",
vnet_type="response";
// From the Cores
MessageBuffer * requestFromCores, network="From", virtual_network="0",
vnet_type="request";
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/33755
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I0eb9e8fc8e25111849605a710a5150ce5fc3b83b
Gerrit-Change-Number: 33755
Gerrit-PatchSet: 3
Gerrit-Owner: Sampad Mohapatra <[email protected]>
Gerrit-Reviewer: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Matt Sinclair <[email protected]>
Gerrit-Reviewer: Sampad Mohapatra <[email protected]>
Gerrit-Reviewer: Srikant Bharadwaj <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-CC: Bradford Beckmann <[email protected]>
Gerrit-CC: Matthew Poremba <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
