Andreas Sandberg has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/34117 )
Change subject: base: Remove unused Debug::All flag
......................................................................
base: Remove unused Debug::All flag
The Debug::All flag doesn't seem to be used. Remove it.
Change-Id: I3d6ad1b2f61a2a0a5c52cbc6d520112855946007
Signed-off-by: Andreas Sandberg <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/34117
Reviewed-by: Jason Lowe-Power <[email protected]>
Reviewed-by: Gabe Black <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/base/debug.cc
M src/base/debug.hh
2 files changed, 0 insertions(+), 31 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/base/debug.cc b/src/base/debug.cc
index b165f64..47febd0 100644
--- a/src/base/debug.cc
+++ b/src/base/debug.cc
@@ -125,35 +125,6 @@
k->disable();
}
-struct AllFlags : public Flag
-{
- AllFlags()
- : Flag("All", "All Flags")
- {}
-
- void
- enable()
- {
- FlagsMap::iterator i = allFlags().begin();
- FlagsMap::iterator end = allFlags().end();
- for (; i != end; ++i)
- if (i->second != this)
- i->second->enable();
- }
-
- void
- disable()
- {
- FlagsMap::iterator i = allFlags().begin();
- FlagsMap::iterator end = allFlags().end();
- for (; i != end; ++i)
- if (i->second != this)
- i->second->disable();
- }
-};
-
-AllFlags theAllFlags;
-Flag *const All = &theAllFlags;
bool
changeFlag(const char *s, bool value)
diff --git a/src/base/debug.hh b/src/base/debug.hh
index 479a830..1d35be0 100644
--- a/src/base/debug.hh
+++ b/src/base/debug.hh
@@ -108,8 +108,6 @@
Flag *findFlag(const std::string &name);
-extern Flag *const All;
-
bool changeFlag(const char *s, bool value);
} // namespace Debug
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/34117
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I3d6ad1b2f61a2a0a5c52cbc6d520112855946007
Gerrit-Change-Number: 34117
Gerrit-PatchSet: 2
Gerrit-Owner: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-CC: Daniel Carvalho <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
