Hoa Nguyen has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/33078 )

Change subject: base: Tag API methods in socket.hh
......................................................................

base: Tag API methods in socket.hh

Change-Id: Ifdbe1d9367df602e45fa3d39c91de9e0f8f1d87e
Signed-off-by: Hoa Nguyen <hoangu...@ucdavis.edu>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/33078
Reviewed-by: Jason Lowe-Power <power...@gmail.com>
Maintainer: Jason Lowe-Power <power...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/base/socket.hh
1 file changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/base/socket.hh b/src/base/socket.hh
index 74a379b..4b42674 100644
--- a/src/base/socket.hh
+++ b/src/base/socket.hh
@@ -32,6 +32,10 @@
 class ListenSocket
 {
   protected:
+    /**
+     * The following variables are only used by socket unit tests:
+     * listeningDisabled, anyListening, bindToLoopback.
+     */
     static bool listeningDisabled;
     static bool anyListening;

@@ -54,14 +58,20 @@


   public:
+    /**
+     * @ingroup api_socket
+     * @{
+     */
     ListenSocket();
     virtual ~ListenSocket();

     virtual int accept(bool nodelay = false);
+
     virtual bool listen(int port, bool reuse = true);

     int getfd() const { return fd; }
     bool islistening() const { return listening; }
+    /** @} */ // end of api_socket
 };

 #endif //__SOCKET_HH__

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/33078
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ifdbe1d9367df602e45fa3d39c91de9e0f8f1d87e
Gerrit-Change-Number: 33078
Gerrit-PatchSet: 4
Gerrit-Owner: Hoa Nguyen <hoangu...@ucdavis.edu>
Gerrit-Reviewer: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Hoa Nguyen <hoangu...@ucdavis.edu>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to